From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 8D3483858D20 for ; Fri, 28 Jul 2023 14:18:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D3483858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id D95B91003FEA3 for ; Fri, 28 Jul 2023 14:18:57 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id POIzq7VfLaShIPOIzqiNgi; Fri, 28 Jul 2023 14:18:57 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SsJVVNC0 c=1 sm=1 tr=0 ts=64c3ce51 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=85Gl0A6RkVXJR0buvIUA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S3y6pSRbctQwIY7gUV2YW0TCu1fAIV+ISVPKxHh4Yh8=; b=oYv4NFYVak5WOXDJUUhEE4Rav2 Kc7pARdlXu2aTYWikZ6j4NI/sltR3KjcgamlATHhHtQHIq6Isxilv5wzOV15FO4iSN+vL2yn/qFPF wFnDsPbYMYOkqVFZ78hTK+TOH; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:54646 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qPOIz-003GN1-0a; Fri, 28 Jul 2023 08:18:57 -0600 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Tom Tromey , Bruno Larsen Subject: Re: [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang References: <20230725095833.236804-1-blarsen@redhat.com> <20230727074118.1583199-1-blarsen@redhat.com> <20230727074118.1583199-4-blarsen@redhat.com> <873518i3ey.fsf@tromey.com> X-Attribution: Tom Date: Fri, 28 Jul 2023 08:18:56 -0600 In-Reply-To: (Bruno Larsen via Gdb-patches's message of "Fri, 28 Jul 2023 15:20:03 +0200") Message-ID: <87tttoglv3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qPOIz-003GN1-0a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:54646 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> I mean, yeah I can, but since it is in a loop, the differences would Bruno> only be a counter at the end of the test case. Are we really getting Bruno> any value from that? To me it seems like it would just boggle down the Bruno> sum file with meaningless "tests" that aren't exercising any relevant Bruno> code paths. I can do it if you disagree, though, it isn't a big deal. Yeah, I don't know if it's useful -- but are any of these passes useful? The problem I think is that the proc can unconditionally emit a fail, so having a corresponding pass seems to make sense. Tom