From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 6/6] Use correct inferior in Inferior.read_memory et al
Date: Fri, 14 Jul 2023 11:05:10 -0600 [thread overview]
Message-ID: <87ttu6mnjt.fsf@tromey.com> (raw)
In-Reply-To: <d9e835c0-4374-9015-f048-7686ce5c9c73@palves.net> (Pedro Alves's message of "Fri, 14 Jul 2023 17:56:58 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>> +gdb_test "python print(astr\[0\])" .*
Pedro> This one game me pause. Did you really intend to accept any
Pedro> output? Should the match be a bit more strict? Otherwise, could
Pedro> you add a comment?
Yeah, it should be more strict.
>> + gdb_test "inferior $num" ".*" "switch to inferior $num"
Pedro> I wouldn't mind making this a little tighter too, since it's so easy, like match:
Pedro> "Switching to inferior $num .*"
I fixed these spots as well.
Will send v4 in a minute.
Tom
prev parent reply other threads:[~2023-07-14 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:05 [PATCH v3 0/6] Fix some Python Inferior methods Tom Tromey
2023-07-13 14:05 ` [PATCH v3 1/6] Minor cleanups in py-inferior.exp Tom Tromey
2023-07-13 14:05 ` [PATCH v3 2/6] Refactor py-inferior.exp Tom Tromey
2023-07-13 14:05 ` [PATCH v3 3/6] Rename Python variable in py-inferior.exp Tom Tromey
2023-07-13 14:05 ` [PATCH v3 4/6] Remove obsolete comment from gdbthread.h Tom Tromey
2023-07-13 14:05 ` [PATCH v3 5/6] Introduce scoped_restore_current_inferior_for_memory Tom Tromey
2023-07-13 14:05 ` [PATCH v3 6/6] Use correct inferior in Inferior.read_memory et al Tom Tromey
2023-07-14 16:56 ` Pedro Alves
2023-07-14 17:05 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttu6mnjt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).