From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id C7C883858D3C for ; Fri, 9 Jun 2023 15:13:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7C883858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 2103510047D76 for ; Fri, 9 Jun 2023 15:13:20 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 7dnkq1DOwbVUp7dnkq2ZlN; Fri, 09 Jun 2023 15:13:20 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=f9iNuM+M c=1 sm=1 tr=0 ts=64834190 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IAzG2lPb+1ljGpdD3lQffRXN1UIEVjzlkHTGextlWrQ=; b=mXVoaOiBzZ2Rcl1JG9Sjbe2Z8u RIgjluvpRJIXES1MHhbunIL5IyCKn+pXAcLTGkNxh6PTUNyYp4p3WT7K7ZEanRzPYHSYx6GgBFX5j prh3otmhKG2uRjjM3PHp2OyY3; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:53560 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q7dnj-0027U6-Rr; Fri, 09 Jun 2023 09:13:19 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom Tromey , Tom de Vries Subject: Re: [PATCH] [gdb/tui] Handle unicode chars in prompt References: <20230526132512.29496-1-tdevries@suse.de> <0c1512d8-0912-044d-6c12-ec93de068b87@suse.de> <875y89wy48.fsf@tromey.com> <678ad6f8-b39e-0f0d-5933-62f81c44d27c@suse.de> <26eace21-84bf-7d9d-051b-93f2bc38edd7@suse.de> X-Attribution: Tom Date: Fri, 09 Jun 2023 09:13:19 -0600 In-Reply-To: <26eace21-84bf-7d9d-051b-93f2bc38edd7@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 9 Jun 2023 00:44:39 +0200") Message-ID: <87ttvg7jow.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1q7dnj-0027U6-Rr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (murgatroyd) [75.166.136.83]:53560 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Sorry, I missed this email when looking at your latest TUI patches. Tom> The logic I used in this patch: Tom> ... Tom> + if (height != nullptr) Tom> + { Tom> + int line = getcury (w); Tom> + *height += line - prev_line; Tom> } Tom> ... Tom> was to use the current line to detect a wrap but that doesn't work if Tom> writing the prompt wraps at the last line which then generates a Tom> scroll. Yeah, I see. This whole thing is maddening to me because ncurses does have a flag that indicates that the output wrapped, and while it is in curses.h, it is clearly non-exported, there's not even an ncurses extension for it. And, PDcurses does not have this. Tom> In conclusion, AFAIU this approach doesn't work. Yeah :( Tom