From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B9EAA3858C27 for ; Fri, 28 Apr 2023 14:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9EAA3858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682693847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uqmVHSn7K26JCAHhW2CygVA0SgvEn7xdA+bSLXJO1wg=; b=TCkhPbgAwqzgxu9MUciCXT0s2v9WWNKwB+R/YiLpv/FU+cLKjCzaaJFfZPXLHPI8nk03GD IYJr8Tdew1lYdItRe+79VWSx01+++mly5I4Azq2Lw8qHZ8vbP6Ty71KqCblC+g24LNd/Qf RU4JD6D+Vbtva/gjk/aYRG9lstFJp1k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-9lPwffiDOKSRipBnbhoNlA-1; Fri, 28 Apr 2023 10:57:22 -0400 X-MC-Unique: 9lPwffiDOKSRipBnbhoNlA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f3157128b4so42406315e9.0 for ; Fri, 28 Apr 2023 07:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682693840; x=1685285840; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uqmVHSn7K26JCAHhW2CygVA0SgvEn7xdA+bSLXJO1wg=; b=Tm9mycrF7PhLSI8eF4X096U/xK66peSHhpNF8Rtpr64iH2K/gKvEP2WkbTjzP6PKJd HrfGFV+4MUQkftFyg9FXP49C0uWw+KNzdlzzVyiUeiD8/0PRxX4tlQRlOt9CY6zpByh4 +R8fC6HYc4oC/CiMPIcV45aSkrB8Zrgy9OvrfE9poEUuG5zwhtikaLUQJpvf2xqmPr6s pr7hivL8coimzw1eFp43yc+MmCTJdFV77f27ks4eGAS7o/VrnZb9guuQmvaIIS264y5V LA9anTZbbANSOv+VmThb0R7RDvvLb5k/2Gv/zMyf4mfWw6JZmygmbqvlEyEvIld+aEVk nd1Q== X-Gm-Message-State: AC+VfDxMeJePUKnimOZkmAhWm0Zg42Ke8jxP1bOfOJUKbNlpqnQgStTz BgaLKiZCnseRXLxwX6cWSoKTtf5M+REY3Ei1OlZptK6sttMAjzPQ6NfEpZuHoTk/E5reDCEhnx4 JORL6LxZY3mnXbVXmuz0u4q6p1uNkMQ== X-Received: by 2002:a05:600c:378e:b0:3f1:65cb:8156 with SMTP id o14-20020a05600c378e00b003f165cb8156mr4018977wmr.0.1682693840608; Fri, 28 Apr 2023 07:57:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DTmVg/XmZbW58IkwdiYC7P4lhimAAcV2i6H0drpDgHPNh9WHVPw2iGLGwWjO2Ebd4f3U42w== X-Received: by 2002:a05:600c:378e:b0:3f1:65cb:8156 with SMTP id o14-20020a05600c378e00b003f165cb8156mr4018967wmr.0.1682693840324; Fri, 28 Apr 2023 07:57:20 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id r17-20020adff711000000b002f2b8cb5d9csm21254752wrp.28.2023.04.28.07.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 07:57:19 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 5/5] gdb: make deprecated_show_value_hack static In-Reply-To: <87pm8231gr.fsf@tromey.com> References: <6fddb814d85dcacfcd3de87404b722d52edcc89e.1680608960.git.aburgess@redhat.com> <87pm8231gr.fsf@tromey.com> Date: Fri, 28 Apr 2023 15:57:18 +0100 Message-ID: <87ttx09hrl.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> The deprecated_show_value_hack function is now only used inside > Andrew> cli-setshow.c, so lets make the function static to discourage its use > Andrew> anywhere else. > > Andrew> There should be no user visible changes after this commit > > FWIW I wouldn't mind if we removed nearly all "show" functions and just > made some variant of deprecated_show_value_hack the standard way to > print things. Instead of munging the help text (which is > i18n-unfriendly) it could just print the option name: > > (gdb) show mumble var > Current setting of "mumble variable": 23 I have a branch which I occasionally work on which is filling in all the missing show functions -- which is the opposite to what you are suggesting. Didn't plan to post it anytime soon though, as I only work on it when I'm /really/ bored. Thanks, Andrew