From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id B79A43858410 for ; Mon, 17 Apr 2023 16:37:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B79A43858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 01B83100482A2 for ; Mon, 17 Apr 2023 16:37:22 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id oRqzpNqaaNX2aoRqzp0Qhe; Mon, 17 Apr 2023 16:37:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=643d75c1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=mLpYvzeL_OdaZ8OXtQUA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4UG0/JAAj5A/CRFdOPRbOw9uZ1vTWuUZwd3Vu42QygY=; b=GcL00S1f6715Ta34DjpXQK0xoj pb7rvubi0QcmKQle2eM+nZ7G/7acdGK7O1GMbsVR6nQu89M/4iTCsyAr94mFntSDt7n8H0HhiYPBp e2yJN5jc58imlJZg96gmFmIoz; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:33292 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poRqz-001pHQ-LF; Mon, 17 Apr 2023 10:37:21 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 2/5] gdb: make set/show args work with $_gdb_setting_str References: <14b084ae3950c36f8e631404975d3468813ef3fc.1680608960.git.aburgess@redhat.com> X-Attribution: Tom Date: Mon, 17 Apr 2023 10:37:20 -0600 In-Reply-To: <14b084ae3950c36f8e631404975d3468813ef3fc.1680608960.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 4 Apr 2023 13:45:28 +0100") Message-ID: <87ttxe31of.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1poRqz-001pHQ-LF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:33292 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> Luckily, the fix is pretty easy, set/show variables have an Andrew> alternative API which requires we provide some getter and setter Andrew> functions. With this done the scratch variable can be removed and the Andrew> value returned will now always reflect the current inferior. Wow, I didn't realize this had been implemented. I think all options requiring the "two phase" approach should be rewritten to this form, and the old form just removed entirely. This is related to https://sourceware.org/bugzilla/show_bug.cgi?id=12188 but not exactly -- I guess we'd have to add a second getter API to convert "auto" parameters to their "current" value. Tom