From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 9E8A13850214 for ; Fri, 24 Mar 2023 16:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E8A13850214 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id h7so1116707ila.5 for ; Fri, 24 Mar 2023 09:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1679674224; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=C8Iein7fKr51j8ukLKLuOP3RgKtgzuXMz/qBiIXHoaU=; b=Xwp2WE/q6VA+PNiSdBl249s78K2DI61aTSiXGwicrRVjHTGjE+HnoL0xyE57QpbMVg ycnD5bbNL/2jCTTeEDeyd1pyuSH34lCtMcsTGKV29A+u8E5rpvex9aumJQ9u7u6WFAPe qOTxxNfH/8EalKE2L2GFvXCy4JZLoRGLIcB7UK44UFEKwYmC+hIOKnxIzEV3WBcSYQPB RptR2QVI3J/0OwN1wbGAlNtWDwVLc9UD72PTkPBppIK9klQVC+P0cHhPBZX9JqaYTAUP qwtF4ifHR9p46q84f7OFL1mbTMNIVa8ErZpod5Tqh1vDmMowUVdT1EUd3hTnfnStqjJr ysDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679674224; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C8Iein7fKr51j8ukLKLuOP3RgKtgzuXMz/qBiIXHoaU=; b=iDKcwtOfu/MtIVW3dJr4vUE8HyNstCYiNPd6385r+vFNFRE9ta4ROpiiXNa3uhfjvY Xh0VY045MaO7qD3hltRCWwebrFirf8ZGIa3Hgtw363tNLGbT+pv1ZAi645dedeX0Qxm0 Xix91gLQPzyquLGXgxyKDSbWm8qztMstw/p0sHqqHYQtMG2MGzds6dEB5ov5IOotvBm3 V0Lcj+LJotgJuaevdR7zucKyBjCBiA4xEisCQkBIMV/zUprivwkogihqQ+sBLfKOi6MU Fe2h5cpHOEKu1AOKY+y7fyneJXtfcMkFERN+kLwuSEgHFFm+izeMr28Q46hnM0PqIPaq FfXg== X-Gm-Message-State: AAQBX9cNPv5nyWFA2VXaIzeeeNvgl2LdChpalArKlmy7kt9RS3bbaXJz OVuu5pVuEo261dBpNZiKlFtbIg== X-Google-Smtp-Source: AKy350Y13FWiJgXDt/ZyEu9/LUPZF1BiyKdRs2sze2HrnHcQWSj35xd/axRef6NWYzTaXqFSM6+2rw== X-Received: by 2002:a92:bf07:0:b0:323:29e2:a19 with SMTP id z7-20020a92bf07000000b0032329e20a19mr2485636ilh.19.1679674223694; Fri, 24 Mar 2023 09:10:23 -0700 (PDT) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id i7-20020a05663815c700b00406147dad72sm6945831jat.104.2023.03.24.09.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 09:10:23 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH 2/3] Handle erroneous DW_AT_call_return_pc References: <20230314-submit-ppc-finish-fixes-v1-0-5f2f461b52f8@adacore.com> <20230314-submit-ppc-finish-fixes-v1-2-5f2f461b52f8@adacore.com> X-Attribution: Tom Date: Fri, 24 Mar 2023 10:10:22 -0600 In-Reply-To: <20230314-submit-ppc-finish-fixes-v1-2-5f2f461b52f8@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 14 Mar 2023 07:37:17 -0600") Message-ID: <87ttyadtap.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> On PPC64, with the test case included in an earlier patch, we found Tom> that "finish" would still not correctly find the return value via Tom> entry values. [...] Tom> I'm not completely sure that the nop check in the new arch hook is Tom> correct; but if it is incorrect it just means that some invocations of Tom> 'finish' won't find a value -- which is what happens without the Tom> patch. Subsequent discussion revealed that the linker might replace this 'nop' with some other instruction, so ... Tom> + unsigned long op = rs6000_fetch_instruction (gdbarch, pc); Tom> + if (op == 0x60000000) Tom> + pc += 4; Tom> + return pc; ... in an updated version I've replaced this with just "return pc + 4". Tom