From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 6E64738515FD for ; Mon, 20 Mar 2023 13:48:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E64738515FD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id B1445100443A2 for ; Mon, 20 Mar 2023 13:48:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id eFs1p8if8ZEg8eFs1pIRyB; Mon, 20 Mar 2023 13:48:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=R+zGpfdX c=1 sm=1 tr=0 ts=64186421 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=20KFwNOVAAAA:8 a=y26Bvzfj-3c2TpXgXE0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ec4IMpWTTaqyj0tNiy42tl5PgUxUrVxeqle5+/lz7UI=; b=R1DaUtT96rCBM3yOVpmC5B1q5k qArP9GOxZV6QbA2kE9R/AOktF0nuUQ8nzuu69aKpxMuN8xHdFN+FCxNl/clCyWML5yjideRHAwkwd PSJ90D328imB803m+7sH06PMB; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:54758 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1peFs1-003vWW-D2; Mon, 20 Mar 2023 07:48:17 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Tom Tromey , Andrew Burgess Subject: Re: [PATCH] Use rust_demangle to fix a crash References: <20230319153506.3382669-1-tom@tromey.com> <87ileveokp.fsf@redhat.com> X-Attribution: Tom Date: Mon, 20 Mar 2023 07:48:14 -0600 In-Reply-To: <87ileveokp.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 20 Mar 2023 09:53:26 +0000") Message-ID: <87ttyfh6u9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1peFs1-003vWW-D2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:54758 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: >> + a C++-compatible mangling, so must come before C++; Ada must come >> + last (see ada_sniff_from_mangled_name). (Keep this order in sync >> + with the 'languages' array in language.c.) */ Andrew> Could you drop the last bit: "(Keep this order in sync with ...". Andrew> This is no longer true, the languages array automatically fills itself Andrew> as the languages are initialised, and always places the entries in the Andrew> correct order. Yep, I removed it. Andrew> Looks good with that change. Andrew> Reviewed-By: Andrew Burgess Thanks, I'm going to check it in. Tom