From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 90D293858D33 for ; Thu, 5 Jan 2023 20:41:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90D293858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 132BE100468CC for ; Thu, 5 Jan 2023 20:41:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DX3Ip1f3jSnieDX3IpLEEZ; Thu, 05 Jan 2023 20:41:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IJ3HtijG c=1 sm=1 tr=0 ts=63b735f8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=7d_E57ReAAAA:8 a=X3z25hUDqNQ3SGdB9F0A:9 a=vLSSZjyX2LUA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lXMRgAzEDh/WZ1bXkUkEd5QrP0qYmA+A+9Ma1BEEMPc=; b=Av+PURxmuqtRIczy0lUeFfPAwF 1dohpgYhSSrBOgtOZYoAuNyEEaPBhn7jMomolHZ5l5eqysIl5TWWOokY1UxldiLW4I3XVktDQj0dk 3lCkFstcvX1mHkh5M/odD7Vs+; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:39158 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDX3H-000ClW-JW; Thu, 05 Jan 2023 13:41:27 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi , Simon Marchi , Andrew Burgess Subject: Re: [PATCH v2 5/8] gdb: add gdbarch_up References: <20230105200237.987771-1-simon.marchi@polymtl.ca> <20230105200237.987771-6-simon.marchi@polymtl.ca> <87y1qgbu5r.fsf@tromey.com> <89b747c9-bc63-b204-d9b4-1a2e3ff1f25a@efficios.com> X-Attribution: Tom Date: Thu, 05 Jan 2023 13:41:24 -0700 In-Reply-To: <89b747c9-bc63-b204-d9b4-1a2e3ff1f25a@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 5 Jan 2023 15:36:04 -0500") Message-ID: <87tu14btor.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pDX3H-000ClW-JW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:39158 X-Source-Auth: tom+tromey.com X-Email-Count: 15 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> On 1/5/23 15:31, Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> Simon> From: Simon Marchi Simon> Add a gdbarch_up unique pointer type, that calls gdbarch_free on Simon> deletion. This is used in the ROCm support patch at the end of this Simon> series. >> >> gdbarch_free is just a wrapper around delete. >> What if this typedef just used the default deleter instead? >> Moving gdbarch to just use new/delete always looks pretty easy. >> >> Tom Simon> I think it would involve moving the struct gdbarch definition from gdbarch.c Simon> to gdbarch-gen.h, right? Ugh, yeah, never mind. It would be nice, maybe, to convert all this so the accessors are inlined and whatnot, but it's a much bigger job. This looks ok to me. Tom