From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 80C863858291 for ; Tue, 3 Jan 2023 14:14:30 +0000 (GMT) Received: by mail-il1-x12f.google.com with SMTP id y2so18064742ily.5 for ; Tue, 03 Jan 2023 06:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=IGCV1GVkdWwvYBty+GML9FVxLvT+rATX9daCahF2U2g=; b=XP3kgzX9KMdCmZDdwtlhg2hw82+q7tt81hON4/Ykq0/S1tUxhDBRTo1aCP9dUZPGKf Da6RoJeZ2/MuCl2108BFPwNXOvVnHKaruNNfW0LLIT34rzdqEaWNLLQhENSVzJkj1t7O zmMgC5YX/NVLIx89XPqoaKzTBUBGw7aFUxz9IkYG+f1I0vU+phrBf62Up2yXgBAxcXk6 +w3oAd5e4aSoglQHCRvi0vppJnl4qSKPah85g0+P6gEoUjNVXK7AoDO1jOCeqYZW0lOP w13hUQq6hhVXTSc4b404s7iZTaKe9vAtY8yxxjKJfB7uNEGDYqFGi0NBq4sjh9O8lvQ8 Y+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IGCV1GVkdWwvYBty+GML9FVxLvT+rATX9daCahF2U2g=; b=SCkwDKVRfzG9CHXIV8Q9A99B43ctJeMZ8YGDHYl1hHnaNlQz1DS69IhYOawRv99syS 1iW9fSaARpUlyAWSbrFTaFNRnUosaeEUxdRHc1F95AqDfu+DlAJajva47DnUGywa2oDi kLzVShmyGY5mmzFL3p9QfejYUVP/JWvjFM1NM2ugJwnELq0kKgq8VtEcH1Jzv3D8k4+p jBast1ugN/mKjVTfgYUxpE3Eh07hTOKJsnOwkSIeNPsPbL2jJnZRsmgpDkgzb0VgnB7j gxc3+JSDL8LmVmnZ/wXIxj2T/JqaAvN0HsUV4zpXwlCtdiyV5lAActMqysyijPmwf4+7 d5jA== X-Gm-Message-State: AFqh2kpdz/OccJOMfTV7iTXmKTQFfCcvz8VCTwKx+VgIkMmkbBg+yqdH HNc7BhgiAD2djv0FSXH860FhT4nunffloQcE X-Google-Smtp-Source: AMrXdXtmkyFX1S74pkNezaA/3CiRsY3+vF2xPHYWVa8vMSpslEqSkIVC751IJ6p1MQ0moVNvTM5ttw== X-Received: by 2002:a05:6e02:1a02:b0:30c:67cb:3b32 with SMTP id s2-20020a056e021a0200b0030c67cb3b32mr714023ild.19.1672755269739; Tue, 03 Jan 2023 06:14:29 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id m8-20020a927108000000b003024b62725dsm9685627ilc.22.2023.01.03.06.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 06:14:29 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol References: <20220901163059.3678708-1-tromey@adacore.com> <87bkrk8j21.fsf@tromey.com> <877d1duivp.fsf@tromey.com> <87k024khch.fsf@tromey.com> <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> X-Attribution: Tom Date: Tue, 03 Jan 2023 07:14:28 -0700 In-Reply-To: <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> (Tom de Vries's message of "Tue, 3 Jan 2023 09:04:17 +0100") Message-ID: <87tu17iu2j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c: In member Tom> function =E2=80=98virtual void dap_interp::init(bool)=E2=80=99: Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: error: Tom> =E2=80=98PyObject_CallNoArgs=E2=80=99 was not declared in this scope Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); Tom> ^~~~~~~~~~~~~~~~~~~ Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: note: Tom> suggested alternative: =E2=80=98_PyObject_CallNoArg=E2=80=99 Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); Tom> ^~~~~~~~~~~~~~~~~~~ Tom> _PyObject_CallNoArg Tom> ... Sorry about that. I'm going to apply the appended, which should fix the problem. Tom commit 5aea5eca6c873334deb41f996dec255786a6f84d Author: Tom Tromey Date: Tue Jan 3 07:13:01 2023 -0700 Do not use PyObject_CallNoArgs =20=20=20=20 PyObject_CallNoArgs was introduced in Python 3.9, so avoid it in favor of PyObject_CallObject. diff --git a/gdb/python/py-dap.c b/gdb/python/py-dap.c index 8e977bc55bb..9c77b2a4f76 100644 --- a/gdb/python/py-dap.c +++ b/gdb/python/py-dap.c @@ -1,6 +1,6 @@ /* Python DAP interpreter =20 - Copyright (C) 2022 Free Software Foundation, Inc. + Copyright (C) 2022, 2023 Free Software Foundation, Inc. =20 This file is part of GDB. =20 @@ -80,7 +80,7 @@ dap_interp::init (bool top_level) if (func =3D=3D nullptr) gdbpy_handle_exception (); =20 - gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); + gdbpy_ref<> result_obj (PyObject_CallObject (func.get (), nullptr)); if (result_obj =3D=3D nullptr) gdbpy_handle_exception (); =20