public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Jonas Hoerberg via Gdb-patches <gdb-patches@sourceware.org>
Cc: Jonas Hoerberg <JHorberg@danfoss.com>
Subject: Re: [PATCH] Fix target remote pipe command for MinGW
Date: Mon, 02 Jan 2023 08:10:32 -0700	[thread overview]
Message-ID: <87tu19j7kn.fsf@tromey.com> (raw)
In-Reply-To: <AM0PR01MB58445D93A19496D0404E195BDAE89@AM0PR01MB5844.eurprd01.prod.exchangelabs.com> (Jonas Hoerberg via Gdb-patches's message of "Thu, 22 Dec 2022 15:22:17 +0000")

>>>>> "Jonas" == Jonas Hoerberg via Gdb-patches <gdb-patches@sourceware.org> writes:

Jonas> The cced7cacecad104fff0 ("gdb: preserve `|` in connection details string")
Jonas> commit added '|' detection and removal to ser-pipe.c, but missed to add it
Jonas> to ser-mingw.c.

Jonas> This results in the error message below for MinGW hosts:
Jonas> error starting child process '| <executable> <args>': CreateProcess: No such file or directory

Jonas> This commit add the missing '|' detection and removal to ser-mingw.c.

Thank you for the patch.  I'm going to push it now and also apply it to
the gdb 13 branch.

If you plan to write more patches for gdb, contact me off-list and we
can get the copyright assignment paperwork started.

thanks,
Tom

      reply	other threads:[~2023-01-02 15:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 15:22 Jonas Hoerberg
2023-01-02 15:10 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu19j7kn.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=JHorberg@danfoss.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).