From: Tom Tromey <tom@tromey.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Tom Tromey <tom@tromey.com>,
Markus Metzger via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb, btrace: fix family and model computation
Date: Tue, 25 Oct 2022 10:55:32 -0600 [thread overview]
Message-ID: <87tu3rc06z.fsf@tromey.com> (raw)
In-Reply-To: <DM8PR11MB574972ADC28913DA450EA312DE2E9@DM8PR11MB5749.namprd11.prod.outlook.com> (Markus T. Metzger's message of "Mon, 24 Oct 2022 08:19:47 +0000")
> In fact,
> bb368aad297 gprofng: a new GNU profiler
> added the same functionality, so now we have two versions of it. I tried
> to unify them (attached) but wasn't able to pass gprofng tests on my box.
> They already fail without my changes.
> I could replace this patch with the attached two. What do you think?
I wouldn't hold up your patch for this, but if you wanted to coordinate
with the gprofng folks and get this new patch in, it does seem better to
consolidate the code.
Tom
next prev parent reply other threads:[~2022-10-25 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 12:13 Markus Metzger
2022-10-21 15:30 ` Tom Tromey
2022-10-24 8:19 ` Metzger, Markus T
2022-10-25 16:55 ` Tom Tromey [this message]
2022-10-28 6:46 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu3rc06z.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).