From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id E83C63858439 for ; Tue, 19 Jul 2022 12:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E83C63858439 Received: by mail-io1-xd2c.google.com with SMTP id y2so11596622ior.12 for ; Tue, 19 Jul 2022 05:23:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6G7LyQjWL7k3QRj/LVHHB/+3BHEOu0GmzyLbuwHa22I=; b=yIFjX83VdHEg8h9XIbONc5nJgxq1bw58NOQHl4ckzdOpcf5AnwtD96zX0sUDnlEz0b Wv8ey3OcjHCNl9i2rKvWOKv05l+4ZjvCk9HabhEVQ5ghVrT5uGDvXgjNg1Y6JKH5lwQ8 +Ro6L19JBbY8208AkTcBd7RRYsSH/4b9rtOsyUsmM90s313YrrVsvxH+mC2qf1Qnj/FH PZkkjog/y14YdEwqGCMAeQ/KhK8kCJI/bV2z6Vof6vvTH7MRiMzlvzJ/h1JZEOukgmdO DD6S1T1GJW4Y9Y0PpsKOlWW1yNYLjbL/R1smPqmu3WiZpauH7llVEfBYA/o5Tvep4TgS wqdg== X-Gm-Message-State: AJIora87cKW4AIXmA877p1zXzesAncbtdevt0VpPEaWvkPIPxYbc43as hfJVwQ5BET8vQl2184F3e5cAZg== X-Google-Smtp-Source: AGRyM1sZ911T5K/E3082v1jmc+EtHxiLAh4CYLLWoqJT4rbLP/VqSPTqEFjLT1JGywwheGEqTO0xEQ== X-Received: by 2002:a6b:c505:0:b0:67c:dcd:a5b2 with SMTP id v5-20020a6bc505000000b0067c0dcda5b2mr4681721iof.37.1658233400180; Tue, 19 Jul 2022 05:23:20 -0700 (PDT) Received: from murgatroyd (71-211-185-228.hlrn.qwest.net. [71.211.185.228]) by smtp.gmail.com with ESMTPSA id f6-20020a056e020b4600b002dae42fa5f2sm5817896ilu.56.2022.07.19.05.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 05:23:19 -0700 (PDT) From: Tom Tromey To: "Metzger, Markus T" Cc: Tom Tromey , Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-11-markus.t.metzger@intel.com> <87fsiyl5pp.fsf@tromey.com> X-Attribution: Tom Date: Tue, 19 Jul 2022 06:23:18 -0600 In-Reply-To: (Markus T. Metzger's message of "Tue, 19 Jul 2022 07:13:57 +0000") Message-ID: <87tu7djnpl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 12:23:22 -0000 >> I think this function is used by linespec, meaning it's called when >> setting a breakpoint. So in this case, limiting the results to the >> current namespace seems possibly incorrect to me. >> >> Was there a particular reason for this limitation? > I was simply trying to preserve the existing behavior of not knowing about > linker namespaces. I didn't really read through the rest of the series -- was this the rule followed elsewhere? I think it shouldn't be, because in gdb a linespec should find all the matches. > Would you want me to drop the patch to keep the objfile traversal and > collect all symbols from all namespaces? I think so. Tom