From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id F40593857BBD for ; Fri, 15 Jul 2022 19:40:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F40593857BBD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 79F8710041EEF for ; Fri, 15 Jul 2022 19:40:21 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CRAjo9e8CCokGCRAjotsPA; Fri, 15 Jul 2022 19:40:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=d+QwdTvE c=1 sm=1 tr=0 ts=62d1c2a5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=xkVI2swuAAAA:20 a=fs_ISM9RipCL8A28v5AA:9 a=2cZglfnkQzV9rT_l5ESa:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xTD1S4ZCDEMgG37HPQH2vkdXMzad+xl29GUflmt7rZs=; b=JYH3ZiRK5xqxkG7zgfzZl7G3an +2qgtFBHdti2MY5xGIX9Dt7LX/vZxQqSeIZzkR4yvQ+Q8McL+WTNsi9Sq/yf22rGRoT312ciBk0bF k4qmUvjCPCRwAH5f+dp7icPNU; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56132 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCRAi-000HZz-Sk; Fri, 15 Jul 2022 13:40:20 -0600 From: Tom Tromey To: Andrei Pikas Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 (mentions of reverse mode eliminated)] Add style tui-cursorline command to colorize TUI current line. References: <83sfn91rvt.fsf@gnu.org> <20220710101003.4245-1-gdb@mail.api.win> X-Attribution: Tom Date: Fri, 15 Jul 2022 13:40:20 -0600 In-Reply-To: <20220710101003.4245-1-gdb@mail.api.win> (Andrei Pikas's message of "Sun, 10 Jul 2022 13:10:03 +0300") Message-ID: <87tu7imafv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oCRAi-000HZz-Sk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56132 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 19:40:33 -0000 >>>>> "Andrei" == Andrei Pikas writes: Andrei> Adds the ability to customize the colors of the current line of code in TUI. Andrei> This may be desirable when code highlighting is enabled. Because higlighted Andrei> keywords in dark blue color are indistinguishable from a black background Andrei> (which is the default inverse color for a white terminal). Andrei> Here is a screenshot of old and new behavior Andrei> https://drive.google.com/file/d/1BbgNwpFa0DvKX0K9UAd48dEgtn8aChXP/view Thank you for the patch. Andrei> +set style tui-cursorline foreground COLOR Andrei> +set style tui-cursorline background COLOR I think I'd prefer a hyphen in there, since "cursorline" isn't a word. So, tui-cursor-line. But why "cursor" and not "current"? "current line" seems to be the term used in the gdb manual. Andrei> @@ -54,6 +54,28 @@ static const char * const cli_colors[] = { Andrei> "magenta", Andrei> "cyan", Andrei> "white", Andrei> + "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", What's this for? Andrei> +static bool Andrei> +get_custom_cursorline_style (ui_file_style *style) Andrei> +{ Please add an introductory comment explaining the purpose of the function. Andrei> + ui_file_style cursorline_style = tui_cursorline_style.style(); Space before "(". There are a couple instances of this here. Andrei> case '\n': Andrei> + if (wattr_get (w, &w_attrs, &w_pair, nullptr) == OK) Andrei> + /* Apply current style till the end of line. */ Andrei> + wchgat (w, -1, w_attrs, w_pair, nullptr); I don't think this is correct, because the source window may not extend to the end of the line. Tom