From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 4E8473857433 for ; Mon, 4 Jul 2022 19:54:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E8473857433 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 97409100442CB for ; Mon, 4 Jul 2022 19:54:02 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 8S8wonxdpSReQ8S8wocwr4; Mon, 04 Jul 2022 19:54:02 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=MPylJOVl c=1 sm=1 tr=0 ts=62c3455a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=odwyD-aVJyhupOErc6AA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kVcI+FpujXb4K/Q3xpZAjvlkLJllcBsPf7smNwu08ZE=; b=Tk10tsk0gcAnBoffCEr2M9WJW3 my5m+azVgxA7NfYwuKzPx1OZYSwSiI7Q9DO4ECAG8iT11gV9BJESnDIjvscM1w5IDFV56pEbYTFaK 5Z/08HK3mxkSO70+JHnyfQS1/; Received: from 71-211-187-180.hlrn.qwest.net ([71.211.187.180]:35196 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o8S8v-000NGb-Vc; Mon, 04 Jul 2022 13:54:02 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] [gdb/symtab] Fix data race on per_cu->dwarf_version References: <20220629152914.13149-1-tdevries@suse.de> <20220629152914.13149-2-tdevries@suse.de> <58c8a00c-a931-8f97-ef05-66f404a6756a@suse.de> <2c75174c-8468-ba23-a30d-c8f99dc9589a@suse.de> <87y1x8u2xd.fsf@tromey.com> <50e85ba1-a050-f460-df4f-8bd3663b0c41@suse.de> X-Attribution: Tom Date: Mon, 04 Jul 2022 13:53:57 -0600 In-Reply-To: <50e85ba1-a050-f460-df4f-8bd3663b0c41@suse.de> (Tom de Vries's message of "Mon, 4 Jul 2022 21:43:47 +0200") Message-ID: <87tu7wu016.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.187.180 X-Source-L: No X-Exim-ID: 1o8S8v-000NGb-Vc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-187-180.hlrn.qwest.net (prentzel) [71.211.187.180]:35196 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 19:54:07 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> On 7/4/22 20:51, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: Tom> Fix this by setting the field earlier, in >> read_comp_units_from_section. >> Thanks. Tom> The write in cutu_reader::cutu_reader() is still needed, in >> case Tom> read_comp_units_from_section is not used (run the test-case with say, target Tom> board cc-with-gdb-index). >> I wonder if we should just change this code to always scan the DWARF >> just enough to read the headers. Like, would that really be so much >> slower? (Eons ago I thought so but now I don't really know.) If it >> would simplify the code it seems like it would be a net win. Tom> I wondered the same, but then including the top-level die. That would Tom> allow us to get the language before going into the parallel for. But Tom> I suppose that's more complex than just the headers. Yeah, that's harder since it would have to read abbrevs, etc. This part of the reader is a real mess. There is a seemingly redundant copy of the header info as well, used by DWO. This is surprisingly hard to untangle :( Tom