From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8EBC23856DDB for ; Mon, 4 Jul 2022 10:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EBC23856DDB Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509--5B_9NhXOYuPJI2WK1xQAA-1; Mon, 04 Jul 2022 06:15:19 -0400 X-MC-Unique: -5B_9NhXOYuPJI2WK1xQAA-1 Received: by mail-wm1-f69.google.com with SMTP id j19-20020a05600c191300b003a048196712so5117398wmq.4 for ; Mon, 04 Jul 2022 03:15:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=MhHmvwRJ/iZfujFGICjXW2LhkXFQwnBUGZ4ALoBr8j4=; b=uaLDM2BXk8Sjg4jR+6dpArMHunmAywaluH+e5Fdr4GTA8EuVCmxMrMZtf12jQlkVj6 35/IVzmX4hwiIcWa/IfQW5QPWUFlWHDRoxRTHebkxuMJ06RMbMT3sWVizwwzPmawYoy6 PHv6vBCZUupBQuUA26D5dyClgTPrs9t79k0g+Vp/0g55Gf35HRO9r0jDRvaEcPJc40dF f4B1eTTHm/9o+ZbcktczL2xxttRFE2nqGcsmV8QiVhBkRtzoLNbSA0siA9d/ZsZ7jaiD yu/Hr0hPlyjIDG2gb6IbAxn70wVE3TEll+bIXAsBRMvYWfi3QRVzMXSlkhk8MhIEkJbj IElw== X-Gm-Message-State: AJIora+nrOx8OO+GK121zeDIfiihR18b7HzFM6g9nJG1awolwsIwwxTV SlkczgJfn11qc9DlQ2LOVPxSLJ+vUJ4LGAbwoRQ9kpPl746lUAsScXFCuvpCYzWkQqmEDStjYsH NnyIbXior0OAJK6dXKnYfuw== X-Received: by 2002:a05:600c:22da:b0:3a0:4e7b:4237 with SMTP id 26-20020a05600c22da00b003a04e7b4237mr29776993wmg.101.1656929717799; Mon, 04 Jul 2022 03:15:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tuGmN9uRVZSFgUqPSNWOD0Ib9wpF19YZDv3TaU8pz+WJpjBwmepKQNUd7yulJ12C7UUkUblg== X-Received: by 2002:a05:600c:22da:b0:3a0:4e7b:4237 with SMTP id 26-20020a05600c22da00b003a04e7b4237mr29776976wmg.101.1656929717637; Mon, 04 Jul 2022 03:15:17 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id m32-20020a05600c3b2000b0039744bd664esm15799379wms.13.2022.07.04.03.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 03:15:17 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: add support for disassembler styling using libopcodes In-Reply-To: <831qv65knj.fsf@gnu.org> References: <835ykzpmjz.fsf@gnu.org> <87a69ucpdo.fsf@redhat.com> <831qv65knj.fsf@gnu.org> Date: Mon, 04 Jul 2022 11:15:15 +0100 Message-ID: <87tu7xb2vg.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 10:15:21 -0000 Eli Zaretskii via Gdb-patches writes: >> From: Andrew Burgess >> Cc: gdb-patches@sourceware.org >> Date: Thu, 30 Jun 2022 13:22:27 +0100 >> >> Thanks for your feedback. The updated patch below I believe addresses >> all these issues. > > It does, thanks. One last nit: > >> + disasm_mnemonic_style.add_setshow_commands (no_class, _("\ >> +Disassembler mnemonic display styling.\n\ >> +Configure the colors and display intensity for instruction mnemonics\n\ >> +in the disassembler output. The \"disassembler mnemonic\" style is\n\ >> +used to displaying instruction mnemonics as well as any assembler\n\ > ^^^^^^^^^^^^^ > Either "to display" or "for displaying". Thanks. This fix will be included in the final version of this patch. Andrew