Re: [PATCH v4 18/34] Introduce the new DWARF index class

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> This patch introduces the new DWARF index class.  It is called
Tom> "cooked" to contrast against a "raw" index, which is mapped from disk
Tom> without extra effort.

I was experimenting with this code and I found a bug.

Tom> +  const cooked_index_entry *parent = parent_entry;
Tom> +  if (tag == DW_TAG_enumeration_type && (flags & IS_ENUM_CLASS) == 0)
Tom> +    parent = parent->parent_entry;

I think this is incorrect.  First, it should probably refer to
DW_TAG_enumerator -- but even that would be wrong because this case is
already handled in the scanner:

	      /* We need to recurse even for an anonymous enumeration.
		 Which scope we record as the parent scope depends on
		 whether we're reading an "enum class".  If so, we use
		 the enum itself as the parent, yielding names like
		 "enum_class::enumerator"; otherwise we inject the
		 names into our own parent scope.  */
	      info_ptr = recurse (reader, info_ptr,
				  ((flags & IS_ENUM_CLASS) == 0)
				  ? parent_entry
				  : this_entry,
				  fully);

So I think the solution is to remove this code from the index.

I'll see if I can come up with a test case.
I don't expect a big delay in landing this series, though.

Tom