From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 58E853858D20 for ; Tue, 15 Mar 2022 22:17:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 58E853858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 8F53E10047F96 for ; Tue, 15 Mar 2022 22:17:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id UFTdn9VlmY8ycUFTenlPDK; Tue, 15 Mar 2022 22:17:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ue6U9IeN c=1 sm=1 tr=0 ts=6231106a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=oqLtY0dxY5HE57jfFF4A:9 a=QYH75iMubAgA:10:nop_sms_unsolicited DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sZI7czOv9KmUN9aI5i5ro1sn5YgpNoHBKwyPGSKPlz0=; b=sl4KDQyXLgOX3raRH69JejDoq6 gBZ2g1epuSTC5msbS+gbjB3IALK83a2Ih1Onscf1L3EP1j5OviZ4eIy0/+Mxa0WzzPKIeiQqDlR1Z KsVKLK+wqPRxiKNJE0Ge4JlEV; Received: from [161.98.8.2] (port=42170 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUFTd-002OiF-LK; Tue, 15 Mar 2022 16:17:13 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use function view when iterating over block symbols References: <20220304234002.5545-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 15 Mar 2022 16:17:12 -0600 In-Reply-To: (Simon Marchi's message of "Tue, 15 Mar 2022 10:54:53 -0400") Message-ID: <87tuby274n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.2 X-Source-L: No X-Exim-ID: 1nUFTd-002OiF-LK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.2]:42170 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 22:17:16 -0000 Simon> I see some tests failing in gdb.trace since this patch. Sorry about that. Simon> I can't really Simon> explain it, but I tracked it down to this capture by reference. 'pc' is assigned to later in the function. The new closure uses the updated value, but the old code did not. I'm checking in the appended. I verified that the test failed before the patch and passes after. I didn't see this in the original patch because I didn't run gdbserver tests. Tom