From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id CA4B03858D39 for ; Fri, 4 Mar 2022 16:42:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA4B03858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 1FE6E100478C3 for ; Fri, 4 Mar 2022 16:42:34 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QB0jnmj5Tkku4QB0jn4aCW; Fri, 04 Mar 2022 16:42:34 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SP+H6MjH c=1 sm=1 tr=0 ts=6222417a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=fIDO4juM1g6HkLK8Y3cA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aOOyZ0U4RmMIdn+QVQ1nSl/97MUvvBLTsNsQYrFdeYk=; b=P9rzhVvWPm15g0sRiDzYHPIJKm jAOCrH5fFJQE6GkJssB/WMSzmYxUtjBBdcyexmr2h0qi9pn8nr0p5i8fn+8q+Yi3vDuJcbhZCj0jZ gA7luwdw6GBV5q2rWhfft1h0f; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37916 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQB0j-002IOq-BP; Fri, 04 Mar 2022 09:42:33 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv2 10/15] gdb/tui: fairer distribution of excess space during apply References: <0f4e96b9c174b9a841d8549421cf8d04d8a82b3b.1644156219.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 04 Mar 2022 09:42:32 -0700 In-Reply-To: <0f4e96b9c174b9a841d8549421cf8d04d8a82b3b.1644156219.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Sun, 6 Feb 2022 14:12:48 +0000") Message-ID: <87tucdsm87.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nQB0j-002IOq-BP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37916 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 16:42:36 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> In this commit, rather than add all the extra space to one single Andrew> window, I instead hand out the extra space 1 line at a time, looping Andrew> over all the sub-layouts. We take care to respect the min/max sizes, Andrew> and so, we now get this result: I think this patch should also update this comment a bit earlier in the function: /* If there is any leftover size, just redistribute it to the last resizeable window, by dropping it from the allocated size. We could try to be fancier here perhaps, by redistributing this size among all windows, not just the last window. */ ... because now the fancier thing is done. I'm not sure any more if this comment correctly explains the following 'if', so I don't know if the comment can just be removed or if it needs some kind of rewording. Tom