From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 341D5386EC4B for ; Fri, 14 Jan 2022 19:42:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 341D5386EC4B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id A0A5710047025 for ; Fri, 14 Jan 2022 19:42:21 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 8SSrnaZFQnAlU8SSrnRe9u; Fri, 14 Jan 2022 19:42:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QIOt+iHL c=1 sm=1 tr=0 ts=61e1d21d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=D-apjPbYqQ142ed_2MsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d8KDc7IWRMWUzN+ZT1gh5vb2GmVjmX8vggZ70Dhf9iE=; b=szfd1Iitcu9E5gykcJEabOc9qO 3epNbsdRrPvQoDOFaD/GEw4DoNkMg7dYI9B3hjSHCEvnay9iYbB1x23SpNaWkSrjPMJ0+qsQr9Jng p7saJGgj8kOnw6rVWbVkKXBxm; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55892 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n8SSq-0040sQ-RP; Fri, 14 Jan 2022 12:42:20 -0700 From: Tom Tromey To: Christina Schimpe via Gdb-patches Subject: Re: [PATCH 3/3] gdb: Remove workaround for the vCont packet References: <20220113152118.1465255-1-christina.schimpe@intel.com> <20220113152118.1465255-4-christina.schimpe@intel.com> X-Attribution: Tom Date: Fri, 14 Jan 2022 12:42:20 -0700 In-Reply-To: <20220113152118.1465255-4-christina.schimpe@intel.com> (Christina Schimpe via Gdb-patches's message of "Thu, 13 Jan 2022 16:21:18 +0100") Message-ID: <87tue6f6jn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n8SSq-0040sQ-RP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55892 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 19:42:23 -0000 >>>>> ">" == Christina Schimpe via Gdb-patches writes: >> The workaround for the vCont packet is no longer required due to the >> former commit "gdb: Make global feature array a per-remote target array". >> The vCont packet is now checked once when the connection is started and >> the supported vCont actions are set to the target's remote state >> attribute. Thank you for the patch. >> + /* Check vCont support and set the remote state's vCont_action_support >> + attribute. */ >> + remote_vcont_probe (); >> - if (m_features.packet_support (PACKET_vCont) == PACKET_SUPPORT_UNKNOWN) >> - remote_vcont_probe (); It seems like the new code should probably check whether the packet is supported like the old code did, in case the gdb user disabled it using the appropriate "set remote" command. Tom