From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 1/4] gdb: new 'maint flush source-cache' command
Date: Mon, 10 Jan 2022 08:18:41 -0700 [thread overview]
Message-ID: <87tuebmxf2.fsf@tromey.com> (raw)
In-Reply-To: <96703b6e331430c39078c96bba0fe0edee5c83e5.1641565040.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 7 Jan 2022 14:23:11 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> +static void
Andrew> +source_cache_flush_command (const char *command, int from_tty)
Andrew> +{
Andrew> + forget_cached_source_info ();
Andrew> + if (from_tty)
Andrew> + printf_filtered (_("Source cache flushed.\n"));
For a maint command in particular, I'd say unconditionally printing is
fine.
This looks good to me.
Tom
next prev parent reply other threads:[~2022-01-10 15:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 14:23 [PATCH 0/4] Source highlight non utf-8 characters using Python Andrew Burgess
2022-01-07 14:23 ` [PATCH 1/4] gdb: new 'maint flush source-cache' command Andrew Burgess
2022-01-07 14:49 ` Eli Zaretskii
2022-01-11 12:13 ` Andrew Burgess
2022-01-11 13:31 ` Eli Zaretskii
2022-01-12 11:38 ` Andrew Burgess
2022-01-10 15:18 ` Tom Tromey [this message]
2022-01-07 14:23 ` [PATCH 2/4] gdb: erase items from the source_cache::m_offset_cache Andrew Burgess
2022-01-10 15:24 ` Tom Tromey
2022-01-11 12:17 ` Andrew Burgess
2022-01-11 14:54 ` Tom Tromey
2022-01-12 11:38 ` Andrew Burgess
2022-01-07 14:23 ` [PATCH 3/4] gdb: add 'maint set/show gnu-source-highlight enabled' command Andrew Burgess
2022-01-07 14:53 ` Eli Zaretskii
2022-01-11 13:07 ` Andrew Burgess
2022-01-11 13:34 ` Eli Zaretskii
2022-01-12 11:37 ` Andrew Burgess
2022-01-10 15:58 ` Tom Tromey
2022-01-07 14:23 ` [PATCH 4/4] gdb/python: handle non utf-8 characters when source highlighting Andrew Burgess
2022-01-10 3:27 ` Simon Marchi
2022-01-10 10:41 ` Andrew Burgess
2022-01-10 15:32 ` Simon Marchi
2022-01-11 13:10 ` Andrew Burgess
2022-01-11 19:24 ` Tom Tromey
2022-01-11 19:42 ` Patrick Monnerat
2022-01-12 14:30 ` [PATCHv2 0/2] Source highlight non utf-8 characters using Python Andrew Burgess
2022-01-12 14:30 ` [PATCHv2 1/2] gdb/python: add gdb.host_charset function Andrew Burgess
2022-01-12 15:02 ` Eli Zaretskii
2022-01-12 15:23 ` Tom Tromey
2022-01-12 16:05 ` Andrew Burgess
2022-01-12 14:30 ` [PATCHv2 2/2] gdb/python: handle non utf-8 characters when source highlighting Andrew Burgess
2022-01-12 15:32 ` Tom Tromey
2022-01-12 15:59 ` Andrew Burgess
2022-01-19 17:44 ` Andrew Burgess
2022-01-21 16:59 ` Simon Marchi
2022-01-26 23:13 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuebmxf2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).