From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.93]) by sourceware.org (Postfix) with ESMTPS id E28713858410 for ; Wed, 17 Nov 2021 00:20:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E28713858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 4D12B14FC2 for ; Tue, 16 Nov 2021 18:20:34 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n8gkmI8r3SJXrn8gkm6qQl; Tue, 16 Nov 2021 18:20:34 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wCnvOVc+gYi7T2axDi8sCgY+tdADXXFB4YMWAeMU/eI=; b=HxxDB+ptgoAN/GQFcKS2xv8hUe GfTldzIn1gl2gfJv6Pv3Sv7Wqfm3b1mIuGHM/D8lB0p2MsWLFV4rEtebneavx6ALkkeQsCUlCe7Bq O+KVcxwg8fdLEpfAj/XQupf0A; Received: from [161.98.8.2] (port=58464 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mn8gj-003IiC-VX; Tue, 16 Nov 2021 17:20:34 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi via Gdb-patches Subject: Re: [PATCH 2/4] gdbsupport: add array_view copy function References: <20211108210609.353208-1-simon.marchi@efficios.com> <20211108210609.353208-2-simon.marchi@efficios.com> <87h7cbesar.fsf@tromey.com> <90ddca61-ea64-b354-6fb4-99ab607a43d6@efficios.com> X-Attribution: Tom Date: Tue, 16 Nov 2021 17:20:33 -0700 In-Reply-To: <90ddca61-ea64-b354-6fb4-99ab607a43d6@efficios.com> (Simon Marchi's message of "Tue, 16 Nov 2021 16:56:13 -0500") Message-ID: <87tugbzl7y.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.2 X-Source-L: No X-Exim-ID: 1mn8gj-003IiC-VX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (localhost.localdomain) [161.98.8.2]:58464 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 00:20:44 -0000 >> In C++20 I think we could use std::copy by having the array view >> iterators implement the contiguous_iterator concept. So, maybe a >> comment to this effect would be good. Simon> Do you mean we could use std::copy to implement this copy function, Simon> instead of using memcpy, and that would deal with the details of copying Simon> in the most efficient manner? Yeah, but IIUC it will only use memcpy or whatever if it sees the contiguous_iterator concept (and if the content type is trivially copyable). I'm not sure if there's a way to get this behavior before C++20 though. Tom