From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.200]) by sourceware.org (Postfix) with ESMTPS id 38639385140C for ; Mon, 14 Jun 2021 20:22:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38639385140C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id B2139F70B4 for ; Mon, 14 Jun 2021 15:22:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id st6blKjPyQ18xst6blzmM8; Mon, 14 Jun 2021 15:22:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=N0XgHcr+eZpTK1im6bYiAN8a9OvJospaHRB7i4+RMko=; b=I2F+VUvnFJ8rHayznktFr6ZoO6 moz9b2bLzyO6x1OEVL7lN97MePj4KFPeQ4rVb+dazSuxPOJVuNIJJpO6thX7ooOTmlF03Xjqpbllv nnRTEZBgAPV1GXMNQ2ffOig4H; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:35164 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lst6b-003d2d-Az; Mon, 14 Jun 2021 14:22:45 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Simon Marchi , Tom Tromey , Keith Seitz Subject: Re: [PATCH][gdb/symtab] Fix infinite recursion in dwarf2_cu::get_builder(), again References: <20210609162305.GA7082@delia.home> X-Attribution: Tom Date: Mon, 14 Jun 2021 14:22:44 -0600 In-Reply-To: <20210609162305.GA7082@delia.home> (Tom de Vries's message of "Wed, 9 Jun 2021 18:23:06 +0200") Message-ID: <87tum0xkkr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lst6b-003d2d-Az X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (localhost.localdomain) [97.122.81.113]:35164 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 20:22:48 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> ISTM that the ancestor implementation is confusing and fragile, and should Tom> go. Furthermore, it seems that keeping track of the m_builder in scope can be Tom> handled simply with a global variable. I'd rather not have any global variables. Maybe a new member of dwarf2_per_objfile would be equivalent. Tom> + gdb_assert (dwarf2_cu::sym_cu == nullptr); Tom> + scoped_restore restore_sym_cu = make_scoped_restore (&dwarf2_cu::sym_cu); Tom> + dwarf2_cu::sym_cu = cu; You can pass 'cu' as a second argument to make_scoped_restore. thanks, Tom