From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.228]) by sourceware.org (Postfix) with ESMTPS id 8ECF33857812 for ; Thu, 1 Apr 2021 17:56:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8ECF33857812 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 2C881400D2349 for ; Thu, 1 Apr 2021 12:56:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S1YOlquoLw11MS1YOlb0Zk; Thu, 01 Apr 2021 12:56:24 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c/8QfoNqMV1cKsWbU8QmjeI6YJGAhmLR7Ckx+FG4RjM=; b=mkdEWvTnP3avwWYasCMDAq/NvH Ig/rL6OoHgVXb//phwh2psdLSCvAYxDjX6gE5NA0FL9EHA4ES/WjX7/HqNkCwv3WizcYcWEXRAZwd 14ig5JKQTgZaTArp1UsTCm3Bj; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:44564 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lS1YN-001HJl-SR; Thu, 01 Apr 2021 11:56:23 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH v2] gdb: make gdbpy_parse_command_name return a unique_xmalloc_ptr References: <20210323175546.3836508-1-simon.marchi@polymtl.ca> <20210323183846.3886585-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 01 Apr 2021 11:56:23 -0600 In-Reply-To: <20210323183846.3886585-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 23 Mar 2021 14:38:46 -0400") Message-ID: <87tuopopmg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lS1YN-001HJl-SR X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:44564 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 17:56:25 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> * python/python-internal.h (gdbpy_parse_command_name): Return Simon> gdb::unique_xmalloc_ptr. Simon> * python/py-cmd.c (gdbpy_parse_command_name): Likewise. Simon> (cmdpy_init): Adjust. Simon> * python/py-param.c (parmpy_init): Adjust. Simon> (add_setshow_generic): Take gdb::unique_xmalloc_ptr, release it Simon> when done. Looks good. Simon> + /* We (unfortunately) currently leak the command name. */ Simon> + cmd_name.release (); I wonder if the issue here is that two copies would need to be made, because add_setshow_* makes two commands. Tom