From: Tom Tromey <tom@tromey.com>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 18/22] Update the source location with Frame.select
Date: Thu, 11 Mar 2021 14:53:35 -0700 [thread overview]
Message-ID: <87tuph4asg.fsf@tromey.com> (raw)
In-Reply-To: <20210306174102.21597-9-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 6 Mar 2021 18:40:58 +0100")
>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
Hannes> If the optional argument is True, then the current source location is
Hannes> also updated, the same as if 'frame #' were used.
Hannes> With this, a following 'list' call will show the source location of the
Hannes> current frame instead of the previous one, and the TUI source window is
Hannes> also updated.
Hannes> + if (update_sal)
Hannes> + {
Hannes> + set_current_sal_from_frame (fi);
Hannes> +
Hannes> +#ifdef TUI
Hannes> + if (tui_active)
Hannes> + tui_frame_changed ();
Hannes> +#endif
I'm not sure this is the correct way to do this.
Maybe you need to do what frame_command_core does:
if (get_selected_frame () != prev_frame)
gdb::observers::user_selected_context_changed.notify (USER_SELECTED_FRAME);
Tom
next prev parent reply other threads:[~2021-03-11 21:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210306174102.21597-1-ssbssa.ref@yahoo.de>
2021-03-06 17:40 ` [PATCH 10/22] Add optional styled argument to gdb.execute Hannes Domani
2021-03-06 17:40 ` [PATCH 11/22] Use styled argument of gdb.execute() for cccw command Hannes Domani
2021-03-06 17:40 ` [PATCH 12/22] Add optional full_window argument to TuiWindow.write Hannes Domani
2021-03-06 18:13 ` Eli Zaretskii
2021-03-11 21:49 ` Tom Tromey
2021-03-06 17:40 ` [PATCH 13/22] Use the full_window argument of TuiWindow.write to prevent flickering Hannes Domani
2021-03-06 17:40 ` [PATCH 14/22] Add set_tui_auto_display python function Hannes Domani
2021-03-06 17:40 ` [PATCH 15/22] Disable automatic display while the display window is active Hannes Domani
2021-03-06 17:40 ` [PATCH 16/22] Show raw flag in info display Hannes Domani
2021-03-06 17:40 ` [PATCH 17/22] Use the raw flag of automatic display to disable pretty printers Hannes Domani
2021-03-11 21:47 ` Tom Tromey
2021-03-06 17:40 ` [PATCH 18/22] Update the source location with Frame.select Hannes Domani
2021-03-11 21:53 ` Tom Tromey [this message]
2021-03-06 17:40 ` [PATCH 19/22] Refresh the TUI source window when changing the frame in the frame window Hannes Domani
2021-03-06 18:13 ` [PATCH 10/22] Add optional styled argument to gdb.execute Eli Zaretskii
2021-03-08 10:01 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuph4asg.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).