From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.59]) by sourceware.org (Postfix) with ESMTPS id AEE643894C22 for ; Thu, 11 Mar 2021 21:53:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AEE643894C22 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id C8DB52F38F for ; Thu, 11 Mar 2021 15:53:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KTFQlbglSA1KVKTFQlutQm; Thu, 11 Mar 2021 15:53:36 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pnVfWIt5dmQbQzcm1ibjqPhwlcZr182QGU4mmX3us9s=; b=neMrK9vMP/X1GU5NKtFrL2xtoC sZcOiQrWMHfi3VRch9kg94O32j+bm0AIbZxatgTOUx16dSmAbWx0O5UNV5Koyj35mTyQoFTAJ0xIl gTcwaCmoInJkawC8+XnTJBtjW; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:35618 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lKTFQ-000qDH-9h; Thu, 11 Mar 2021 14:53:36 -0700 From: Tom Tromey To: Hannes Domani via Gdb-patches Subject: Re: [PATCH 18/22] Update the source location with Frame.select References: <20210306174102.21597-1-ssbssa@yahoo.de> <20210306174102.21597-9-ssbssa@yahoo.de> X-Attribution: Tom Date: Thu, 11 Mar 2021 14:53:35 -0700 In-Reply-To: <20210306174102.21597-9-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Sat, 6 Mar 2021 18:40:58 +0100") Message-ID: <87tuph4asg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lKTFQ-000qDH-9h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:35618 X-Source-Auth: tom+tromey.com X-Email-Count: 29 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 21:53:39 -0000 >>>>> "Hannes" == Hannes Domani via Gdb-patches writes: Hannes> If the optional argument is True, then the current source location is Hannes> also updated, the same as if 'frame #' were used. Hannes> With this, a following 'list' call will show the source location of the Hannes> current frame instead of the previous one, and the TUI source window is Hannes> also updated. Hannes> + if (update_sal) Hannes> + { Hannes> + set_current_sal_from_frame (fi); Hannes> + Hannes> +#ifdef TUI Hannes> + if (tui_active) Hannes> + tui_frame_changed (); Hannes> +#endif I'm not sure this is the correct way to do this. Maybe you need to do what frame_command_core does: if (get_selected_frame () != prev_frame) gdb::observers::user_selected_context_changed.notify (USER_SELECTED_FRAME); Tom