From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.234]) by sourceware.org (Postfix) with ESMTPS id 8E67B385782B for ; Tue, 20 Oct 2020 20:17:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8E67B385782B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 11F792FC3 for ; Tue, 20 Oct 2020 15:17:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Uy4akw6s8OIGpUy4bk2W74; Tue, 20 Oct 2020 15:17:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hDsq5ITWh5k2A7vLjZp2MsrZAmnaZ+3V0KT+hYzCH+Y=; b=ZiYmFWueUoBBHZGYr8eHO3MOZs xOOJr4oz6BbdYNTPhcFmbecYYEy97nHouRNl18lA/4BdsIVSdOAorkCWguFvgR8mRNlbD61cUoOGB Pb6b/NgWmTd/gY7Z6U5xyUYPO; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:54444 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kUy4a-000Ozi-OB; Tue, 20 Oct 2020 14:17:32 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv5 3/4] gdb/fortran: add support for parsing array strides in expressions References: <02f3e9f571844809528e74c2a8621b4ec467e22f.1602439661.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Tue, 20 Oct 2020 14:17:31 -0600 In-Reply-To: <02f3e9f571844809528e74c2a8621b4ec467e22f.1602439661.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Sun, 11 Oct 2020 19:12:12 +0100") Message-ID: <87tuuoirdw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kUy4a-000Ozi-OB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (murgatroyd) [75.166.102.113]:54444 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2020 20:17:36 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> With this commit GDB now understands the syntax of Fortran array Andrew> strides, a user can type an expression including an array stride, but Andrew> they will only get an error informing them that array strides are not Andrew> supported. Andrew> This alone is an improvement on what we had before in GDB, better to Andrew> give the user a helpful message that a particular feature is not Andrew> supported than to just claim a syntax error. Aside from the test suite nit that Simon pointed out, this looks good to me. Tom