public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Pedro Alves <palves@redhat.com>,  gdb-patches@sourceware.org
Subject: Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
Date: Fri, 30 Nov 2018 19:49:00 -0000	[thread overview]
Message-ID: <87tvjymjli.fsf@tromey.com> (raw)
In-Reply-To: <20181009134747.GA1742@delia> (Tom de Vries's message of "Tue, 9	Oct 2018 15:47:47 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2018-10-09  Tom de Vries  <tdevries@suse.de>
Tom> 	* gdb.base/gdb-caching-proc.exp: New file.

Thanks for the patch.  I didn't see a review or see this go in, so
hopefully this isn't redundant.

Tom> +# Test gdb_caching_proc NAME
Tom> +proc test_proc { name } {
Tom> +    set real_name gdb_real__$name
Tom> +
Tom> +    set first [$real_name]
Tom> +    lappend resultlist $first

I think this lappend is unnecessary...

Tom> +    set resultlist [list]

... because resultlist is reset here.
But maybe you intended to hoist this earlier?
Either way is fine by me.

This is ok with this nit addressed.

Tom

  parent reply	other threads:[~2018-11-30 19:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 17:40 [PATCH][gdb/testsuite] Fix target_supports_scheduler_locking raciness Tom de Vries
2018-10-09 12:58 ` Pedro Alves
2018-10-09 13:47   ` [gdb/testsuite] Add gdb-caching-proc.exp testcase Tom de Vries
2018-11-05  9:05     ` [PING][gdb/testsuite] " Tom de Vries
2018-11-30 19:49     ` Tom Tromey [this message]
2018-12-01  8:04       ` [gdb/testsuite] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvjymjli.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).