public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Sort objects in gdb and gdbserver Makefiles
Date: Sun, 16 Sep 2018 14:12:00 -0000	[thread overview]
Message-ID: <87tvmpo7kd.fsf@tromey.com> (raw)
In-Reply-To: <20180916125141.6672-2-simon.marchi@polymtl.ca> (Simon Marchi's	message of "Sun, 16 Sep 2018 08:51:41 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Tom mentioned this a while ago, as a way to give you a cheap sense of
Simon> progression in your build, as all object files will be built
Simon> alphabetically (including the directory part).  I tried it and I think
Simon> it's nice.

Simon> gdb/ChangeLog:

Simon> 	* Makefile.in (LIBGDB_OBS): Sort COMMON_OBS.

Simon> gdb/gdbserver/ChangeLog:

Simon> 	* Makefile.in (gdbserver$(EXEEXT)): Sort OBS.
Simon> 	(gdbreplay$(EXEEXT)): Sort GDBREPLAY_OBS.
Simon> 	($(IPA_LIB)): Sort IPA_OBJS.

I think it is a nice idea.

The only counter-case I could think of would be if gdb had some object
whose build time was notably slower than everything else.  In that case
you'd want to start it earlier for better parallelization.

However I don't think that's the case, or at least I haven't noticed;
and anyway it isn't like we've micro-optimized the build that way
anyhow.

Tom

  reply	other threads:[~2018-09-16 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-16 12:51 [PATCH 1/2] gdbserver/Makefile.in: Remove ADD_DEPS Simon Marchi
2018-09-16 12:51 ` [PATCH 2/2] Sort objects in gdb and gdbserver Makefiles Simon Marchi
2018-09-16 14:12   ` Tom Tromey [this message]
2018-09-16 20:08   ` Tom Tromey
2018-09-17  0:40     ` Simon Marchi
2018-09-17  3:46       ` Tom Tromey
2018-09-16 14:10 ` [PATCH 1/2] gdbserver/Makefile.in: Remove ADD_DEPS Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvmpo7kd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).