From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9489 invoked by alias); 8 Jan 2014 15:41:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9480 invoked by uid 89); 8 Jan 2014 15:41:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2014 15:41:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s08FffH6010751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Jan 2014 10:41:41 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s08Ffexx031129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 8 Jan 2014 10:41:40 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] General ada-valprint improvements References: <1389068515-10129-1-git-send-email-brobecker@adacore.com> <87r48jhfa8.fsf@fleche.redhat.com> <20140108113517.GL3802@adacore.com> Date: Wed, 08 Jan 2014 15:41:00 -0000 In-Reply-To: <20140108113517.GL3802@adacore.com> (Joel Brobecker's message of "Wed, 8 Jan 2014 15:35:17 +0400") Message-ID: <87txdecwgc.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00212.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> I'm curious to know what differences you are thinking of. Joel> Sure! Joel> valprint.c:val_print does a few things that value_print does not. Joel> For instance, it handles TYPE_STUB, options->summary, etc. Thanks. Joel> For Ada, I think untangling the extra stuff in ada_value_print Joel> could be done by simply splitting it in two. For val_print, Joel> I haven't even really looked at it yet. Just one of those many Joel> things at the back of my mind. I have an ancient branch where I took a stab at removing val_print. It's a reasonably large patch and still doesn't even compile: 30 files changed, 262 insertions(+), 486 deletions(-) It's quite a big job and due to the way that most languages wind up deferring to the C printer, I didn't see a nice way to do it incrementally. Tom