From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Keith Seitz <keiths@redhat.com>
Subject: Re: [Patch] Use "<unknown>" instead of NULL when a symbol isn't found
Date: Mon, 06 Jan 2014 20:19:00 -0000 [thread overview]
Message-ID: <87txdglv7l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAEG7qUzqKpfakRh+5rD_4B+HDajdhRxsLqgxz5C=UyDGyLoOHA@mail.gmail.com> (Sterling Augustine's message of "Mon, 23 Dec 2013 15:17:19 -0800")
>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:
Tom> I wonder whether some correction or workaround is required elsewhere.
Sterling> There are various parts of linepec.c that assume that this field is
Sterling> never null, either by assertion or by dereferencing it. Any other
Sterling> workaround (at least for the case I'm dealing with) would probably
Sterling> just print an error message.
Yeah, I meant more whether the symbol-reading code should try to
diagnose and avoid broken debuginfo here.
Tom
prev parent reply other threads:[~2014-01-06 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 19:21 Sterling Augustine
2013-12-19 18:11 ` Sterling Augustine
2013-12-20 18:16 ` Tom Tromey
2013-12-23 23:17 ` Sterling Augustine
2014-01-06 20:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txdglv7l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).