From: ludo@gnu.org (Ludovic Courtès)
To: gdb-patches@sourceware.org
Cc: guile-user@gnu.org
Subject: Re: [PATCH v2 02/13] script language API for GDB: extension.[ch]
Date: Fri, 03 Jan 2014 21:11:00 -0000 [thread overview]
Message-ID: <87txdklqk4.fsf@gnu.org> (raw)
In-Reply-To: <CAP9bCMQx_pDKsRTDv5h62kqO4==MTJ80XsZ2RYfpzsjDT1u68g@mail.gmail.com>
Doug Evans <xdje42@gmail.com> skribis:
> On Mon, Dec 23, 2013 at 1:57 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Doug" == Doug Evans <xdje42@gmail.com> writes:
>>
>> Doug> +void
>> Doug> +clear_quit_flag (void)
>> Doug> +{
>> Doug> + int i;
>> Doug> + const struct extension_language_defn *extlang;
>> Doug> +
>> Doug> + ALL_ENABLED_EXTENSION_LANGUAGES (i, extlang)
>> Doug> + {
>> Doug> + if (extlang->ops->clear_quit_flag != NULL)
>> Doug> + extlang->ops->clear_quit_flag (extlang);
>> Doug> + }
>> Doug> +
>> Doug> + quit_flag = 0;
>> Doug> +}
>>
>> I don't think this will work properly. It seems to me that a given
>> interrupt may be processed multiple times -- once by each extension
>> language.
>
> Guile doesn't provide the same hooks that Python does for SIGINT
> (PyErr_SetInterrupt, et.al.) so I expect this part to need some work.
>
>> The way it works right now, if Python handles the "quit", then Python
>> clears the flag -- which also clears gdb's notion of the flag, because
>> the two are identical.
>>
>> With the above it seems that Python could clear its flag -- but leave
>> other extension languages unaware that the interrupt was handled. So, a
>> subsequent call into Guile will presumably erroneously throw an
>> exception.
>
> We carefully manage entry and exit to/from extension languages.
> It should be possible to manage SIGINT across these boundaries.
> v3 coming up, but I'm leaving this part to v4.
Iâm not sure I understand the problem.
What part of the code calls signal(2) or sigaction(2) in the end? There
can only be one SIGINT handler in the process anyway, so I guess it
has to be installed by GDB (the extension-language-independent part), no?
What are extension languages typically expected to do when the âquitâ
flag is set?
(And happy new year, where applicable! ;-))
Ludoâ.
next prev parent reply other threads:[~2014-01-03 21:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 5:11 Doug Evans
2013-12-23 21:57 ` Tom Tromey
2013-12-24 18:05 ` Doug Evans
2014-01-03 21:11 ` Ludovic Courtès [this message]
2014-01-06 21:53 ` Tom Tromey
2014-01-07 13:10 ` Ludovic Courtès
2014-01-07 16:03 ` Tom Tromey
2014-01-07 23:05 ` Ludovic Courtès
2014-01-08 3:17 ` Tom Tromey
2014-01-14 19:17 ` Tom Tromey
2014-01-15 14:52 ` Ludovic Courtès
2014-01-22 4:26 ` Mark H Weaver
2014-01-22 4:36 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txdklqk4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guile-user@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).