From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20511 invoked by alias); 6 Nov 2013 21:16:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20502 invoked by uid 89); 6 Nov 2013 21:16:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2013 21:16:31 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA6LGKjn007085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Nov 2013 16:16:20 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA6LGIOL005217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 6 Nov 2013 16:16:19 -0500 From: Tom Tromey To: "Pierre Muller" Cc: "'Keith Seitz'" , "'gdb-patches'" Subject: Re: [RFC 1/6 -V2] Fix display of tabulation character for mingw hosts. References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <002c01cebaf2$89798ea0$9c6cabe0$@muller@ics-cnrs.unistra.fr> <524A230B.5020304@redhat.com> <10182.1932978512$1380614580@news.gmane.org> Date: Wed, 06 Nov 2013 21:24:00 -0000 In-Reply-To: <10182.1932978512$1380614580@news.gmane.org> (Pierre Muller's message of "Tue, 1 Oct 2013 10:02:37 +0200") Message-ID: <87txfpmdst.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00149.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> 2013-10-01 Pierre Muller Pierre> Fix display of tabulation character for MinGW hosts. Pierre> * gdb_wchar.h (gdb_iswprint): Declare as external function Pierre> if __MINGW32__ macro is set. Pierre> (HAVE_MINGW_GDB_ISWPRINT): New macro, declared only for Pierre> MinGW hosts using wide characters. Pierre> * mingw-hdep.c (gdb_iswprint): New function. Pierre> Implemented only if HAVE_MINGW_GDB_ISWPRINT macro is defined. If this is just for working around one mingw bug in one spot in gdb, I think on the whole it would be simpler to just check for \t directly in print_wchar. I think with a short comment it will be simpler in the end than a new macro and a new host-specific function. Tom