From: Tom Tromey <tom@tromey.com>
To: "Alexandra Hájková" <ahajkova@khirnov.net>
Cc: gdb-patches@sourceware.org, ahajkova@redhat.com
Subject: Re: [PATCH v2] Add "error_message+" feature to qSupported
Date: Fri, 10 May 2024 12:01:56 -0600 [thread overview]
Message-ID: <87v83l1r6z.fsf@tromey.com> (raw)
In-Reply-To: <20240509121126.78317-1-ahajkova@khirnov.net> ("Alexandra =?utf-8?B?SMOhamtvdsOhIidz?= message of "Thu, 9 May 2024 14:11:23 +0200")
>>>>> "Alexandra" == Alexandra Hájková <ahajkova@khirnov.net> writes:
Thank you for the patch.
Alexandra> +@item E.errtext
Alexandra> +An error can be sent as a string. This reply is only valid
Alexandra> +if the @code{error-message feature} (@pxref{error-message}) is enabled.
Should this instead read: "if the @code{error-message} feature"?
That is, I think @code should probably only apply to the feature name.
Other than this nit, this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-05-10 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 12:11 Alexandra Hájková
2024-05-10 18:01 ` Tom Tromey [this message]
2024-05-10 18:46 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v83l1r6z.fsf@tromey.com \
--to=tom@tromey.com \
--cc=ahajkova@khirnov.net \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).