From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 926DB3858425 for ; Wed, 20 Mar 2024 15:35:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 926DB3858425 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 926DB3858425 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710948946; cv=none; b=xTq5utdv0nSMP8HBdSyNbJWEzP8x9ppfl0TxyVtHBTPHA0p7+SBv/g0LI/g7MhFHY+ULLW9E6yLd0aJKc2NSOozTyxC9leGerp2BGL2cXatZ6ySNXSHAeSqEZKOR6hJ2KpTE+1BT+pc+Mm2LUzenpRNRKPHrsTAqzKH4y6FCbBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710948946; c=relaxed/simple; bh=UZydTFc+mGCWALglAIQDZI5Sq3vcN7sPImxa3m5855w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=voEWpt+opxgirLP7FWz8QAphq8NEVOyNm20+dDUJVuM2zIn9g+ZicgCUfRINQ7JVk++cOHF0+sSDoK1GvB5F1r28UAy6G/hxwdvwwawjsSPAU28mXJOfofdgGFiMOPxmfgMxskzUEO6c/yfxM08Vdc5ETpodQU4FtvoEZM04z9M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id mvbxrlpths4yTmxyZryOha; Wed, 20 Mar 2024 15:35:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mxyYrcmsaYakKmxyYrcEoC; Wed, 20 Mar 2024 15:35:34 +0000 X-Authority-Analysis: v=2.4 cv=a4T79lSF c=1 sm=1 tr=0 ts=65fb0246 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=A8oJy8mYAAAA:8 a=pMeZ_334tj-_H50ZcYwA:9 a=MasS0_dV9q-jaWZIey9J:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KZGXqByWMObFU0XxKSHWWVfs2vyTYxBCzBxyAli97tI=; b=N/ASMpKB0jMvboOSHMlhedydSs QaubWSESyeFMdcM5guvOH33dpWp3hTZn36ShIJCTx5nwkXRQuuHqKl2Cob8Cl8Sm4UKZa0SrKKExb OtVKCP/uXtGFpRjuj+dHxUiPK; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:39816 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rmxyX-00056u-2r; Wed, 20 Mar 2024 09:35:33 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/9] Ignore unsed import in dap/__init__.py References: <20240319-more-flake8-v1-0-893549dbed75@adacore.com> <20240319-more-flake8-v1-3-893549dbed75@adacore.com> X-Attribution: Tom Date: Wed, 20 Mar 2024 09:35:32 -0600 In-Reply-To: <20240319-more-flake8-v1-3-893549dbed75@adacore.com> (Tom Tromey's message of "Tue, 19 Mar 2024 11:33:31 -0600") Message-ID: <87v85ggbln.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rmxyX-00056u-2r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:39816 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOe8xLX2oXFGJR86csWRuLLBM56QevVs2evU00obFrAg4PdpIQtdZ018/OBvR11qE0CliK5lqslAIqriawP4vKYufZeE7kZCBRa9S4caJCs17rGk6wt0 mFzoCXrpafFxk+B8apyUk+F2NjKOUwaj9QjH09XpZ9VlwK2TflZ9Ac60TTQ2nnTn3VckEkfc8U8hxkyKbjZEEwdfoE97bJUUC5U= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> flake8 warns about dap/__init__.py because it has a number of unused Tom> imports. Most of these are intentional: the import is done to ensure Tom> that the a DAP request is registered with the server object. Tom> This patch applies a "noqa" comment to these imports, and also removes Tom> one import that is truly unnecessary. Tom> +from . import breakpoint # noqa: F401 Tom> +from . import bt # noqa: F401 Tom> +from . import disassemble # noqa: F401 I found out 'black' doesn't like this style of comment. Locally I've run black on each patch in this series, and it affected just a couple patches like this, removing the extra whitespace. Tom