From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id CD8D4385829A for ; Mon, 18 Mar 2024 14:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD8D4385829A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD8D4385829A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710771119; cv=none; b=OEmA2+s2qvFgPeCTm9T6vWJYqjfC9Y8Bn9Ix0JoAlMXqyrFFbrkg5FeXWswlSWioTjGjOPbXsyEXkw6X4F39i4RUA76DjZrq7TbAul3DUoCJ4tgrkwkyUL3vdyNi5Kj8Hj/aCeGxbKEqEYxBlqlQsnKFfug1LvEfjXQsXEjf4hk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710771119; c=relaxed/simple; bh=/9YOv1exbLJXYSihDSoNl7yj4duqMcLKDe8OhVrfyq0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bXGPk9MwAVC2VGhTgmu7nC5fq6MrWokA6tLSWaAeelcm+XMsltOhPRIsKvVMihsqS1X9unZQwQfTc3YSKfL7fbMOHhg+/CdLXagJMazMsux7/v7O8ltjYktKSOJFiPgs/JUFolxfxwRvnS3hotz3vCvd7+kzwrXUl7OY+Qx925Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-366ada2ac7bso9778835ab.2 for ; Mon, 18 Mar 2024 07:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710771110; x=1711375910; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=haW7VFBY8ra0gwv2+diz9KlRJc/0meuGpJpjW0IxJtU=; b=LJ1qdrlrqbujfWosYT4FElqJoAYeh5pGEXLcxP/3qyo/nxot+522ez7CNsABX0cEXf 3NniFhd5xcTQno0mfZ+1pSUyq95hDgO5ECfHeLCdN6zQ5KueRs7tJbTy+nT2a/TsZrY4 37/87n2xcRwmc4gqFu0UyKC6i/ZC/n9E5lgPHtWBb7vnml/TKLWGaYfY6O0ybffZp3dL Xh++nm/1ThjuYn7qOX7o9aKME2DCznVCjkB5p8q5HotND+bvHxUzcNzht1duS/qZ/Nf0 qSBScuwZCPFbSXMI2QJW/InCejKNmjrCPKst3+HgTg2EWtNfWutnBy9SBCsJvyxqXV9W IT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710771110; x=1711375910; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=haW7VFBY8ra0gwv2+diz9KlRJc/0meuGpJpjW0IxJtU=; b=hCzzO/mTfR4gKDpIt/LP1ZvXv/17GN8KZiGUPBHuv26ATs9Efvl2r7SDeltyMUiQ4j Jae4PY/tCobe0DRYamt33fNIMlbPtgybtK5KErnmilDBilopybSm9AzkX1f8K2IVr/pS z4JuRX/XXTPx9vl+HXhoduKefY/I4uCg2VmS3Rp9IUOel6r9w/5I8PAUwld0rPtV92Dd ReEhWnvtdr38+gd5ld/oqBq5s4bEZIRN7Pi6F70Ok4Oqq5CdNt6X67eVBHPYb/4zzC6D QEYpnHVZhhW1WAftoMBa4Qxi+/P3UcczQDWf/mDRnVnioUeQ12np+zL9ACz5dY4HIdb0 d7yA== X-Gm-Message-State: AOJu0YwJS/5fi3BnsGhOoYr1IWVJAln4GFXW2g0VbouhUJoQBpVP8laW OEkWi6ITCv+2sOOviJoC8HV0LjpLlRdAskfxxH2asdbzk87fusLlvVOXVwDAwzWrCbs/yu6Q5AA = X-Google-Smtp-Source: AGHT+IERScwiWQo+WYfnTdKAWes4Wx8IdiKDPwFxTNeSWeV5/Kl6R7AQC10KvRE+ynE26bY4k5gvsg== X-Received: by 2002:a92:c98f:0:b0:366:96a3:b1c6 with SMTP id y15-20020a92c98f000000b0036696a3b1c6mr10417081iln.11.1710771110168; Mon, 18 Mar 2024 07:11:50 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id g9-20020a92dd89000000b003664ef72ac6sm2327969iln.68.2024.03.18.07.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 07:11:49 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use string_view in quirk_rust_enum References: <20240214150227.2367977-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 18 Mar 2024 08:11:49 -0600 In-Reply-To: <20240214150227.2367977-1-tromey@adacore.com> (Tom Tromey's message of "Wed, 14 Feb 2024 08:02:27 -0700") Message-ID: <87v85jiq8q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> quirk_rust_enum makes string copies to store in an unordered_map. Tom> However, the original strings have an appropriate lifetime, and so no Tom> copying is needed. With C++17, we can rely on string_view having a Tom> std::hash specialization, so this patch changes this code to use Tom> string_view rather than string. I'm checking this in. Tom