From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by sourceware.org (Postfix) with ESMTPS id 035143858403 for ; Sat, 3 Feb 2024 16:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 035143858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 035143858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706978361; cv=none; b=PmTvqza56G1ZsPMRh/T42oLFzHwT5BunlJse1CQOtaThauAuMZZZAzROJpfFRV0hgPzXsNzCLd/GPKl4hoY18vuuHoM5i9VGXk46Kbi7fARFxLfOL3Z0RcMnyGyGg1sJ0dkPEZlcaIrKdMNTo8fRGnyrS4P3Ru9ZljQkZ1GJsGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706978361; c=relaxed/simple; bh=gofoTx43D8BSfB6y5Z9Bbh6y5fczoFf8NM1uHHQvVxs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rvEIHA32sPQmm4EZ33atzu/vnHHDPQf9rD0lCowqtoLhZmRbsh/qS2bKRF/Ho5SmH6XR+nah86mwk1J9+ABjvNd9ViGjw4+yjHR26jAx0fZPnxr5J6TZxUrm0WGI71tMQo37QVklFDnHmn6kcDtqIB7/OlWXex2xbn8rWJm18EY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-59a9304aef0so1729646eaf.1 for ; Sat, 03 Feb 2024 08:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706978358; x=1707583158; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=6hd1kbEO+tG21yVA7AjnZ0WiLwnU9RKGwET5Oj/In4w=; b=atvOCnkoGZCzHgxMKT3XzskN28sXalmNIUU5gVMwgRG52HhpJvNRw/T2NNXY5PjyXQ X8B0dCLQjf1svxjXSokvp6ae96o5CM3HdS85dTDeWRpGZ9IEA/8GD+Ucg+mwlsVdOXE8 lkOs72mLMn1gHSKUCv/eSZcTnH9EtwQzCj6Bz6E/5vbwWu9faM9OkOfsRtj2h2IvNuKy gbhEdC6I8rO/T2RGTFkWZk6IwJ/d50/AAomthzx/ILg1FGiOvD/zxhIKpL2ontsHG4WV G4jSW6nh8gfeEHk1nyzTt2ByD3Q0bFzjGO51uN6PEuxN++Z+t/skci8hUyhbVfpdZk70 46KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706978358; x=1707583158; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6hd1kbEO+tG21yVA7AjnZ0WiLwnU9RKGwET5Oj/In4w=; b=NPWCiye/Fa25zmUyHSyRua3/WPN/E8MWBkKksjPMsTq0n1t5uAnpyfCTrmuM4EKB0l cRdJlHl5u1cI39AIv2IO19aK4n61uZpEUuLCZMiJTphc/T+VAnDc8ILKtcTv98Hjhdrz dqcLwCf9zwWTmg1IBtAgOQXFcXBPplMPs2X5jU2PSpw81QfMWykeJtMli69DqfKKWeHP yNbEUBcARS3NbncZy++DXz1LqfC6Cy2Jq3WK7RFc5IyyQLrGi72pqNFok8tJHJN5TTRT TUdGRwleXBR/50MF9BQqpM6mxZo9UqSk+uhpYRxZ68QkOf5EY/+ASQrqd68rv5usRTV9 36uQ== X-Gm-Message-State: AOJu0YzMvP7xI80dgn/tY0L5j05fBJeLysWINbxNPnuGnKX8LsCamzLM q71ISKChSdcZHvVz6az02mVUka8sH6mL0A9pWJ+RwL5IgkioTpPKsdEdEl4BU2I= X-Google-Smtp-Source: AGHT+IEWY0XZKdazmvMBvblSgV2IGU+E+M8wrVsrfU6Xspp0MwStwVadB1mSXSaj7Qa454awmhsFXw== X-Received: by 2002:a05:6358:8aa:b0:178:89ab:33fa with SMTP id m42-20020a05635808aa00b0017889ab33famr12869089rwj.2.1706978357863; Sat, 03 Feb 2024 08:39:17 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:2af8:70a3:5426:1571]) by smtp.gmail.com with ESMTPSA id h9-20020a656389000000b005ca0ae17983sm3371458pgv.8.2024.02.03.08.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 08:39:17 -0800 (PST) References: <20240203031408.137939-1-thiago.bauermann@linaro.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: binutils@sourceware.org Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default In-reply-to: <20240203031408.137939-1-thiago.bauermann@linaro.org> Date: Sat, 03 Feb 2024 13:39:15 -0300 Message-ID: <87v875wlho.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sorry, I forgot to cc: the binutils mailing list. Done now. Thiago Jung Bauermann writes: > Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by > default") fixed a mismatch between 64-bit time_t in GDB and system headers > and 32-bit time_t in BFD. > > However, since commit 862776f26a59 ("Finalized intl-update patches") > gnulib's year 2038 support has been accidentally re-enabled =E2=80=94 cau= sing > problems for 32-bit hosts again. The commit split baseargs into > {h,b}baseargs, but this hasn't been done for the code that handles > --disable-year2038. > > This patch restores the intended behaviour. With this change, the number > of unexpected core files goes from 18 to 4. > > Tested on armv8l-linux-gnueabihf. > --- > configure | 3 ++- > configure.ac | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 670684d83d15..6466b97f3ec0 100755 > --- a/configure > +++ b/configure > @@ -10313,7 +10313,8 @@ hbaseargs=3D"$hbaseargs --disable-option-checking" > tbaseargs=3D"$tbaseargs --disable-option-checking" >=20=20 > if test "$enable_year2038" =3D no; then > - baseargs=3D"$baseargs --disable-year2038" > + bbaseargs=3D"$bbaseargs --disable-year2038" > + hbaseargs=3D"$hbaseargs --disable-year2038" > tbaseargs=3D"$tbaseargs --disable-year2038" > fi >=20=20 > diff --git a/configure.ac b/configure.ac > index 88b4800e298f..1300a805fd8d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3432,7 +3432,8 @@ hbaseargs=3D"$hbaseargs --disable-option-checking" > tbaseargs=3D"$tbaseargs --disable-option-checking" >=20=20 > if test "$enable_year2038" =3D no; then > - baseargs=3D"$baseargs --disable-year2038" > + bbaseargs=3D"$bbaseargs --disable-year2038" > + hbaseargs=3D"$hbaseargs --disable-year2038" > tbaseargs=3D"$tbaseargs --disable-year2038" > fi >=20=20 --=20 Thiago