From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [pushed] Fix bug in previous remote unique_ptr change (Re: [PATCH 0/2] Use unique_ptr more in the remote target)
Date: Wed, 20 Dec 2023 16:30:49 -0700 [thread overview]
Message-ID: <87v88se9jq.fsf@tromey.com> (raw)
In-Reply-To: <08f2de94-a450-4bd3-9c3f-2f3916a7cb02@palves.net> (Pedro Alves's message of "Wed, 20 Dec 2023 20:27:35 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> - stop_reply_up reply
Pedro> - = as_stop_reply_up (std::move (rns->pending_event[notif_client_stop.id]));
Pedro> + struct notif_event *notif_event
Pedro> + = rns->pending_event[notif_client_stop.id].get ();
Pedro> + auto *reply = static_cast<stop_reply *> (notif_event);
I wonder if you want checked_static_cast here.
Tom
prev parent reply other threads:[~2023-12-20 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 18:12 [PATCH 0/2] Use unique_ptr more in the remote target Pedro Alves
2023-12-15 18:12 ` [PATCH 1/2] Make cached_reg_t own its data Pedro Alves
2023-12-20 23:48 ` Simon Marchi
2023-12-21 11:11 ` Pedro Alves
2023-12-15 18:12 ` [PATCH 2/2] Complete use of unique_ptr with notif_event and stop_reply Pedro Alves
2023-12-15 19:10 ` [PATCH 0/2] Use unique_ptr more in the remote target Tom Tromey
2023-12-20 20:27 ` [pushed] Fix bug in previous remote unique_ptr change (Re: [PATCH 0/2] Use unique_ptr more in the remote target) Pedro Alves
2023-12-20 23:30 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v88se9jq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).