From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 1BDB93858425 for ; Sun, 29 Oct 2023 16:34:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BDB93858425 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1BDB93858425 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698597268; cv=none; b=C96zqZQHX14vA8P6O4x2poquxE1vN1le1x5dXK3ljsFrIciV+TvpZpDmq/KHZcfS30YqJ0SsZC2AZs4HqgIclC8KNosNmmYYgwClljZ4jgFjlQM2W6DyOKhnEPXdj3CIt9p8eUjxUIF4ZGBNgnZhiYDgU8Uqs0cpfkHrYxCVrow= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698597268; c=relaxed/simple; bh=vlq7Qli+eIy8dw57BvCccrelt9zDyJ12sM7n50WxLbw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TzS3QOX8L5nU6gmnoCLfOoClddBe4sMWuBiCM6qqod4eUQzHxggJ2oaqNV4C1dX34G9AHeRj0h9YySl35/lgHrIHgHoFr7+Vk2RYd0br7NWR0oqPog73L0OkQ+jNjRKFLH2RbSTCju6yeD3ubQ8Qsz13LvseKIidNNQ/Ct062yg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id x6Tkq10VbhqFdx8k5qYjOf; Sun, 29 Oct 2023 16:34:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id x8k3qrKY15ZLUx8k4qU0G0; Sun, 29 Oct 2023 16:34:24 +0000 X-Authority-Analysis: v=2.4 cv=S57KfagP c=1 sm=1 tr=0 ts=653e8990 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=4J3ZFyURjuaKX-12VesA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ul0VfEiflSruIGOIxTqGJDn82DcQ0GsxG6+2KLpVuII=; b=FhOhD2KA6KxlWrfO2LU4YRGcOo L6Vze9J6i8Rf4x/dJsHIXFdkYX1K7Ef1Slns9Nt9lr7h53fduhlJFe9HwFmmxPjCf093GoF3X9xtu XikSPigDfHXH+0e0pB/fzbKo5; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:36056 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qx8k3-0009xq-1U; Sun, 29 Oct 2023 10:34:23 -0600 From: Tom Tromey To: Guinevere Larsen Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Pre-read .debug_aranges section References: <20231014205755.996771-1-tom@tromey.com> <20231014205755.996771-2-tom@tromey.com> <0ffa7f32-114d-fa15-c739-53e88e6e5c28@redhat.com> X-Attribution: Tom Date: Sun, 29 Oct 2023 10:34:43 -0600 In-Reply-To: <0ffa7f32-114d-fa15-c739-53e88e6e5c28@redhat.com> (Guinevere Larsen's message of "Thu, 26 Oct 2023 11:54:07 +0200") Message-ID: <87v8aptmjg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qx8k3-0009xq-1U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:36056 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN0lTePftLIzA55jk0SK9GGO4uarsSBgIcMjTSvKfI/bmDCje/aS1SexdzziErwsKXgkGW+o4CRqGERX0rXb/y/o2NsO5ImSBg0+jJaeYW2gBdVXSnXv y83lfpOlZqwQxWnsu86qbhZGl+7kcAL8epol7OBKGf8eklNC3h3RK4KPPBscujRij0CbfIV1CGnYrbp+pZtxS6LTVIpwJi/N/Pc= X-Spam-Status: No, score=-3018.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Guinevere" =3D=3D Guinevere Larsen writes: Guinevere> =C2=A0=C2=A0=C2=A0 /* True if we have tried to read this section= .=C2=A0 */ Guinevere> So I think it would be better to describe that assert as "assert= that Guinevere> the section has been read" or some other way to make it explicit= that Guinevere> "read" is the past tense. I changed it to /* Caller must ensure that the section has already been read. */ Guinevere> With some small rewording around this bit, everything looks good= to Guinevere> me, Reviewed-By: Guinevere Larsen I'm going to check these in now. Tom