From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH 1/6] [gdb/symtab] Fix uninitialized memory in buildsym_compunit::finish_block_internal
Date: Wed, 30 Aug 2023 14:15:28 -0600 [thread overview]
Message-ID: <87v8cwqobj.fsf@tromey.com> (raw)
In-Reply-To: <20230830191336.15885-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 30 Aug 2023 21:13:31 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> When running test-case gdb.dwarf2/per-bfd-sharing.exp with target board stabs,
Tom> gdb either segfaults or asserts due to reading uninitialized memory, allocated
Tom> here in buildsym_compunit::finish_block_internal:
Tom> ...
Tom> ftype-> set_fields
Tom> ((struct field *)
Tom> TYPE_ALLOC (ftype, nparams * sizeof (struct field)));
Tom> ...
Tom> Fix this by using TYPE_ZALLOC instead.
At first I was curious about the history of what changed here, but now I
see that dwarf2_attach_fields_to_type is doing the zalloc thing, so I
think it's just the usual thing where nobody uses or tests non-DWARF
stuff (and why would they) so it wasn't caught in some earlier change.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-08-30 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 19:13 Tom de Vries
2023-08-30 19:13 ` [PATCH 2/6] [gdb/symtab] Factor out type::{alloc_fields,copy_fields} Tom de Vries
2023-08-30 20:17 ` Tom Tromey
2023-08-31 7:57 ` Tom de Vries
2023-08-30 19:13 ` [PATCH 3/6] [gdb/symtab] Do more zero-initialization of type::fields Tom de Vries
2023-08-30 20:19 ` Tom Tromey
2023-08-30 19:13 ` [PATCH 4/6] [gdb/symtab] Replace TYPE_ALLOC + memset with TYPE_ZALLOC Tom de Vries
2023-08-30 20:20 ` Tom Tromey
2023-08-30 19:13 ` [PATCH 5/6] [gdb/symtab] Replace TYPE_ALLOC + B_CLRALL " Tom de Vries
2023-08-30 20:21 ` Tom Tromey
2023-08-31 8:00 ` Tom de Vries
2023-08-30 19:13 ` [PATCH 6/6] [gdb/symtab] Replace TYPE_ALLOC with TYPE_ZALLOC where required Tom de Vries
2023-08-30 20:26 ` Tom Tromey
2023-08-30 20:15 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8cwqobj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).