Re: [PATCH 2/2] gdb: MI stopped events when unwindonsignal is on

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 3472 bytes --]


Hello Andrew,

Andrew Burgess <aburgess@redhat.com> writes:

> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
>> This test fails:
>>
>> Expecting: ^([
>> ]+)?(terminate called after throwing an instance of 'int'
>> ~"\\nProgram"
>> ~" received signal SIGABRT, Aborted\.\\n"
>> ~"0x[0-9A-Fa-f]+ in [^
>> ]+"
>> \*stopped,reason="signal-received",signal-name="SIGABRT"[^
>> ]+frame=\{addr="0x[0-9A-Fa-f]+",[^
>> ]+\}[^
>> ]+
>> &"Error in testing condition for breakpoint 2:\\n"
>> &"The program being debugged was signaled while in a function called from GDB\.\\n"
>> &"GDB remains in the frame where the signal was received\.\\n"
>> &"To change this behavior use \\"set unwindonsignal on\\"\.\\n"
>> &"Evaluation of the expression containing the function\\n"
>> &"\(cond_throw\(\)\) will be abandoned\.\\n"
>> &"When the function is done executing, GDB will silently stop\.\\n"
>> =breakpoint-modified,bkpt={number="2",type="breakpoint",[^
>> ]+times="1",[^
>> ]+}[
>> ]+[(]gdb[)] 
>> [ ]*)
>> terminate called after throwing an instance of 'int'
>> ~"\nProgram"
>> ~" received signal SIGABRT, Aborted.\n"
>> ~"__pthread_kill_implementation (threadid=281474842417696, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44\n"
>> &"44\t./nptl/pthread_kill.c: No such file or directory.\n"
>> *stopped,reason="signal-received",signal-name="SIGABRT",signal-meaning="Aborted",frame={addr="0x0000fffff7c5f200",func="__pthread_kill_implementation",args=[{name="threadid",value="281474842417696"},{name="signo",value="6"},{name="signo@entry",value="6"},{name="no_tid",value="0"},{name="no_tid@entry",value="0"}],file="./nptl/pthread_kill.c",fullname="./nptl/./nptl/pthread_kill.c",line="44",arch="aarch64"},thread-id="1",stopped-threads="all",core="78"
>> &"Error in testing condition for breakpoint 2:\n"
>> &"The program being debugged was signaled while in a function called from GDB.\n"
>> &"GDB remains in the frame where the signal was received.\n"
>> &"To change this behavior use \"set unwindonsignal on\".\n"
>> &"Evaluation of the expression containing the function\n"
>> &"(cond_throw()) will be abandoned.\n"
>> &"When the function is done executing, GDB will silently stop.\n"
>> =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x0000aaaaaaaa087c",func="foo()",file="/home/tcwg-build/workspace/tcwg_gnu_5/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/tcwg-build/workspace/tcwg_gnu_5/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="29",thread-groups=["i1"],cond="cond_throw ()",times="1",original-location="mi-condbreak-throw.cc:29"}
>> (gdb) 
>> FAIL: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: wait for stop (unexpected output)
>>
>> It looks like the testcase isn't expecting these lines:
>>
>> ~"__pthread_kill_implementation (threadid=281474842417696, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44\n"
>> &"44\t./nptl/pthread_kill.c: No such file or directory.\n"
>
> Thanks for testing this, and highlighting this failure.
>
> I've included an updated patch below.  I've made the test pattern a
> little more general so it should (I hope) handle the lines you are
> seeing.
>
> I'd be grateful if you could retest this new version and let me know if
> you are still seeing the failure.

Thank you for the new version. Unfortunately I still see the failure.
I'm attaching the gdb.log file.

-- 
Thiago



[-- Attachment #2: gdb.log --]
[-- Type: text/plain, Size: 15232 bytes --]

Test run by thiago.bauermann on Mon Aug 14 21:04:10 2023
Native configuration is aarch64-unknown-linux-gnu

		=== gdb tests ===

Schedule of variations:
    tcwg-local

Running target tcwg-local
Using /home/thiago.bauermann/tmp/workspace-2/abe/config/boards/tcwg-local.exp as board description file for target.
Using /home/thiago.bauermann/tmp/workspace-2/abe/builds/hosttools/aarch64-unknown-linux-gnu/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /home/thiago.bauermann/tmp/workspace-2/abe/builds/hosttools/aarch64-unknown-linux-gnu/share/dejagnu/config/unix.exp as generic interface file for target.
Using /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file.
Running /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.exp ...
Executing on build: rm -rf /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw    (timeout = 300)
builtin_spawn -ignore SIGHUP rm -rf /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw
Executing on host: gcc    -fdiagnostics-color=never -c -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/temp/3245298/ccopts.o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/temp/3245298/ccopts.c    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fdiagnostics-color=never -c -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/temp/3245298/ccopts.o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/temp/3245298/ccopts.c
get_compiler_info: gcc-11-3-0
get_compiler_info: gcc-11-3-0
Executing on host: g++  -fno-stack-protector  -fdiagnostics-color=never  -c -g  -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw0.o /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc    (timeout = 300)
builtin_spawn -ignore SIGHUP g++ -fno-stack-protector -fdiagnostics-color=never -c -g -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw0.o /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc
Executing on host: g++  -fno-stack-protector /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw0.o  -fdiagnostics-color=never  -L/home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/libiberty  -g  -lm   -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw    (timeout = 300)
builtin_spawn -ignore SIGHUP g++ -fno-stack-protector /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw0.o -fdiagnostics-color=never -L/home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/libiberty -g -lm -o /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw
builtin_spawn /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex set height 0 -iex set width 0 -data-directory /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/data-directory -i=mi
=thread-group-added,id="i1"
=cmd-param-changed,param="height",value="4294967295"
=cmd-param-changed,param="width",value="4294967295"
(gdb) 
100-gdb-set height 0
100^done
(gdb) 
101-gdb-set width 0
101^done
(gdb) 
show mi-async
&"show mi-async\n"
~"Whether MI is in asynchronous mode is off.\n"
^done
(gdb) 
104-environment-directory -r
104^done,source-path="$cdir:$cwd"
(gdb) 
105-environment-directory /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi
105^done,source-path="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi:$cdir:$cwd"
(gdb) 
105-file-exec-and-symbols /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.mi/mi-condbreak-throw/mi-condbreak-throw
105^done
(gdb) 
Expecting: ^(200-break-insert --qualified -t main[
]+)?(200\^done,bkpt=\{number=".*",type="breakpoint",disp="del",enabled=".*",addr=".*",func="main(\(.*\))?",file=".*",fullname=".*",line=".*",thread-groups=\[.*\],times=".*".*original-location=".*"\}[
]+[(]gdb[)] 
[ ]*)
200-break-insert --qualified -t main
200^done,bkpt={number="1",type="breakpoint",disp="del",enabled="y",addr="0x00000000000008a8",func="main()",file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="36",thread-groups=["i1"],times="0",original-location="-qualified main"}
(gdb) 
PASS: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: breakpoint at main
220-exec-run 
=thread-group-started,id="i1",pid="3245541"
=thread-created,id="1",group-id="i1"
=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="del",enabled="y",addr="0x0000aaaaaaaaa8a8",func="main()",file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="36",thread-groups=["i1"],times="0",original-location="-qualified main"}
=library-loaded,id="/lib/ld-linux-aarch64.so.1",target-name="/lib/ld-linux-aarch64.so.1",host-name="/lib/ld-linux-aarch64.so.1",symbols-loaded="0",thread-group="i1",ranges=[{from="0x0000fffff7fc3c40",to="0x0000fffff7fe2064"}]
220^running
*running,thread-id="all"
(gdb) 
mi_expect_stop: expecting: \*stopped,reason="breakpoint-hit",disp="del",bkptno="[0-9]+",frame={addr="0x[0-9A-Fa-f]+",func="main",args=\[.*\],(?:file="[^
]*.*",fullname="(/[^\n]*/|\\\\[^\\]+\\[^\n]+\\|\\[^\\][^\n]*\\|[a-zA-Z]:[^\n]*\\).*",line="[0-9]+",arch="[^
]*"|from=".*")},thread-id="[0-9]+",stopped-threads=[^
]*
(=thread-selected,id="[0-9]+"
|=(?:breakpoint-created|breakpoint-deleted)[^
]+"
)*[(]gdb[)] 
$
=library-loaded,id="/lib/aarch64-linux-gnu/libstdc++.so.6",target-name="/lib/aarch64-linux-gnu/libstdc++.so.6",host-name="/lib/aarch64-linux-gnu/libstdc++.so.6",symbols-loaded="0",thread-group="i1",ranges=[{from="0x0000fffff7e2de30",to="0x0000fffff7f2ee9c"}]
=library-loaded,id="/lib/aarch64-linux-gnu/libc.so.6",target-name="/lib/aarch64-linux-gnu/libc.so.6",host-name="/lib/aarch64-linux-gnu/libc.so.6",symbols-loaded="0",thread-group="i1",ranges=[{from="0x0000fffff7c07040",to="0x0000fffff7d13f20"}]
=library-loaded,id="/lib/aarch64-linux-gnu/libm.so.6",target-name="/lib/aarch64-linux-gnu/libm.so.6",host-name="/lib/aarch64-linux-gnu/libm.so.6",symbols-loaded="0",thread-group="i1",ranges=[{from="0x0000fffff7b4ca50",to="0x0000fffff7b93ea0"}]
=library-loaded,id="/lib/aarch64-linux-gnu/libgcc_s.so.1",target-name="/lib/aarch64-linux-gnu/libgcc_s.so.1",host-name="/lib/aarch64-linux-gnu/libgcc_s.so.1",symbols-loaded="0",thread-group="i1",ranges=[{from="0x0000fffff7b12bc0",to="0x0000fffff7b20e60"}]
~"[Thread debugging using libthread_db enabled]\n"
~"Using host libthread_db library \"/lib/aarch64-linux-gnu/libthread_db.so.1\".\n"
=breakpoint-modified,bkpt={number="1",type="breakpoint",disp="del",enabled="y",addr="0x0000aaaaaaaaa8a8",func="main()",file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="36",thread-groups=["i1"],times="1",original-location="-qualified main"}
~"\n"
~"Temporary breakpoint 1, main () at /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc:36\n"
~"36\t  int res = foo ();\n"
*stopped,reason="breakpoint-hit",disp="del",bkptno="1",frame={addr="0x0000aaaaaaaaa8a8",func="main",args=[],file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="36",arch="aarch64"},thread-id="1",stopped-threads="all",core="97"
=breakpoint-deleted,id="1"
(gdb) 
PASS: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: mi runto main
Expecting: ^(-gdb-set unwind-on-terminating-exception off[
]+)?(\^done[
]+[(]gdb[)] 
[ ]*)
-gdb-set unwind-on-terminating-exception off
^done
(gdb) 
PASS: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: set unwind-on-terminating-exception
Expecting: ^(222-break-insert -c "cond_throw \(\)" mi-condbreak-throw\.cc:29[
]+)?(222\^done,bkpt=\{number=".*",type=".*",disp=".*",enabled=".*",addr=".*",func="foo\(\)",file=".*mi-condbreak-throw.cc",fullname=".*",line="29",thread-groups=\[.*\],cond="cond_throw \(\)"(,evaluated-by=".*")?,times=".*".*original-location=".*"\}[
]+[(]gdb[)] 
[ ]*)
222-break-insert -c "cond_throw ()" mi-condbreak-throw.cc:29
222^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x0000aaaaaaaaa87c",func="foo()",file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="29",thread-groups=["i1"],cond="cond_throw ()",times="0",original-location="mi-condbreak-throw.cc:29"}
(gdb) 
PASS: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: insert conditional breakpoint
print/d $bpnum
&"print/d $bpnum\n"
~"$1 = 2\n"
^done
(gdb) 
PASS: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: get number for breakpoint
-exec-continue
^running
*running,thread-id="all"
(gdb) 
Expecting: ^([
]+)?(terminate called after throwing an instance of 'int'
~"\\nProgram"
~" received signal SIGABRT, Aborted\.\\n"(?:
~"[^
]+")*
\*stopped,reason="signal-received",signal-name="SIGABRT"[^
]+frame=\{addr="0x[0-9A-Fa-f]+",[^
]+\}[^
]+
&"Error in testing condition for breakpoint 2:\\n"
&"The program being debugged was signaled while in a function called from GDB\.\\n"
&"GDB remains in the frame where the signal was received\.\\n"
&"To change this behavior use \\"set unwindonsignal on\\"\.\\n"
&"Evaluation of the expression containing the function\\n"
&"\(cond_throw\(\)\) will be abandoned\.\\n"
&"When the function is done executing, GDB will silently stop\.\\n"
=breakpoint-modified,bkpt={number="2",type="breakpoint",[^
]+times="1",[^
]+}[
]+[(]gdb[)] 
[ ]*)
terminate called after throwing an instance of 'int'
~"\nProgram"
~" received signal SIGABRT, Aborted.\n"
~"__pthread_kill_implementation (threadid=281474842233376, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44\n"
&"44\t./nptl/pthread_kill.c: No such file or directory.\n"
*stopped,reason="signal-received",signal-name="SIGABRT",signal-meaning="Aborted",frame={addr="0x0000fffff7c5f200",func="__pthread_kill_implementation",args=[{name="threadid",value="281474842233376"},{name="signo",value="6"},{name="signo@entry",value="6"},{name="no_tid",value="0"},{name="no_tid@entry",value="0"}],file="./nptl/pthread_kill.c",fullname="./nptl/./nptl/pthread_kill.c",line="44",arch="aarch64"},thread-id="1",stopped-threads="all",core="97"
&"Error in testing condition for breakpoint 2:\n"
&"The program being debugged was signaled while in a function called from GDB.\n"
&"GDB remains in the frame where the signal was received.\n"
&"To change this behavior use \"set unwindonsignal on\".\n"
&"Evaluation of the expression containing the function\n"
&"(cond_throw()) will be abandoned.\n"
&"When the function is done executing, GDB will silently stop.\n"
=breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x0000aaaaaaaaa87c",func="foo()",file="/home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",fullname="/home/thiago.bauermann/tmp/workspace-2/gdb/gdb/testsuite/gdb.mi/mi-condbreak-throw.cc",line="29",thread-groups=["i1"],cond="cond_throw ()",times="1",original-location="mi-condbreak-throw.cc:29"}
(gdb) 
FAIL: gdb.mi/mi-condbreak-throw.exp: unwind_on_exception=off: wait for stop (unexpected output)
testcase /home/thiago.bauermann/tmp/workspace-2/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.mi/mi-condbreak-throw.exp completed in 1 seconds

		=== gdb Summary ===

# of expected passes		5
# of unexpected failures	1
Executing on host: /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/data-directory --version    (timeout = 300)
builtin_spawn -ignore SIGHUP /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex set height 0 -iex set width 0 -data-directory /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/data-directory --version
GNU gdb (Linaro_GDB-2023.08.14) 14.0.50.20230814-git
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
/home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/gdb version  14.0.50.20230814-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /home/thiago.bauermann/tmp/workspace-2/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/data-directory 

runtest completed at Mon Aug 14 21:04:12 2023