From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 8E8663858D28 for ; Tue, 1 Aug 2023 14:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E8663858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-790ca0ed6d3so11756739f.3 for ; Tue, 01 Aug 2023 07:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690900541; x=1691505341; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=c6DiANydcw6K5QVuZjMJZsGGpJylcFccVkuLCMLC7eQ=; b=ff8cWWPCNfI7ETbfS3Jms4Rl+1NyZSb+zXO3suqWdRx+e8HzWeHUcQzqF3SNP1wcOv 3EZIp3udGChI524vSjWpJshC1SS4D8JqABuqNCWLMYGDeT8pF6SMBIEFKbctCKNFsAV/ OCCg4pAR8VoUIYrrs19/kDrHgx4foTQ9sMQk6YamQNnD2a6PMl7tFXgTLMcOo5oZMQZP t0HT8P/3Y8zW+L1j3Tb9DiGeatxw1t7/xa5epjXeoIa1P7jJRRBMMJHznIZyvfWLFdm/ EooMmnvB2phWl+OyDN327MF4/Y9JqZOMIyp0hrN1Tf3KHeW3inW3amBNqDb2lt/aBfsP ALRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690900541; x=1691505341; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c6DiANydcw6K5QVuZjMJZsGGpJylcFccVkuLCMLC7eQ=; b=XB7nYvQmXP0/CW2utIxmoYDJd8AgMvjWH3PzyGgO6+8g1535ZwKrkXhOq8Ca4oN255 yclT2BJ3ceqK2VAp/ErgBl4c8MA5G2d/5Fx7MzVJn6eTtl1b1YGzWE0XzREO5bqBg8EE GyPn9IROZFDiMY8QH+1B/igOwQ/GkQZG1mgi/X28EnUN5A5TTHSlDtmqGIu9QYQGXggH 85fEb04qeh4n8DtRqbg9BIUCJ6NXXfq51QEKA66JrkfYdkSqriuv7SsLbzoUtSXf4PXG Q14F12okBdlUDD/TQqtIrnTGg5n1/LP3JTjzo//r0R34HU6DEy2eFyypVnXoYf7zM8WZ OWOg== X-Gm-Message-State: ABy/qLbRtjBilydUkz0yrBowoghZnPh6fk5vqlfs0/LrVdl0Wk2eTJaE NTutxuI8VFqAWubgQclXs26D/YdvosotgxsgmRGPDg== X-Google-Smtp-Source: APBJJlFWHLK/ojsFbE4y5Ib36QcI2ALn36nxNhgc2TWMTrDh//0byMPlXcdtsR4Y/EwptPBvdcO89Q== X-Received: by 2002:a92:c56a:0:b0:349:226f:3e6 with SMTP id b10-20020a92c56a000000b00349226f03e6mr6138245ilj.5.1690900540930; Tue, 01 Aug 2023 07:35:40 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id y8-20020a02a388000000b0042b46224650sm3640513jak.91.2023.08.01.07.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 07:35:40 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Fix bug in fixed-point handling References: <20230719152442.67508-1-tromey@adacore.com> <87zg3cf33d.fsf@tromey.com> <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> X-Attribution: Tom Date: Tue, 01 Aug 2023 08:35:39 -0600 In-Reply-To: <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> (Tom de Vries's message of "Mon, 31 Jul 2023 23:41:12 +0200") Message-ID: <87v8dyg79g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> Test-case fails with gcc-9 and earlier: Tom> ... Tom> (gdb) PASS: gdb.ada/fixed_points.exp: scenario=all: print fp4_var / 1 Tom> p Float(Another_Fixed) = Float(Another_Delta * 5)^M Tom> No definition of "another_delta" in current context.^M Tom> (gdb) FAIL: gdb.ada/fixed_points.exp: scenario=all: value of another_fixed Tom> ... Did you happen to try with GCC 10? I'm wondering if the appended is enough or if it should be conditional on gcc 10 specifically. Tom diff --git a/gdb/testsuite/gdb.ada/fixed_points.exp b/gdb/testsuite/gdb.ada/fixed_points.exp index 2edc63f4071..12f1adfc249 100644 --- a/gdb/testsuite/gdb.ada/fixed_points.exp +++ b/gdb/testsuite/gdb.ada/fixed_points.exp @@ -90,8 +90,8 @@ foreach_with_prefix scenario {all minimal} { # This only started working in GCC 11. if {$scenario == "minimal" && [test_compiler_info {gcc-11-*}]} { gdb_test "print fp5_var" " = 3e-19" - } - gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ - "value of another_fixed" + gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ + "value of another_fixed" + } }