From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/2] gdb/testsuite: accept script argument for mi_make_breakpoint_pending
Date: Thu, 13 Apr 2023 07:48:00 -0600 [thread overview]
Message-ID: <87v8hz6ghb.fsf@tromey.com> (raw)
In-Reply-To: <86d8058f882e24a361ed7ae385b3bfc02fadfc0c.1681211875.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 11 Apr 2023 12:19:16 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> This commit changes mi_make_breakpoint_pending to accept the 'script'
Andrew> and 'times' arguments.
Andrew> I've then added a new test that makes use of 'scripts' in
Andrew> gdb.mi/mi-pending.exp and gdb.mi/mi-dprintf-pending.exp.
Andrew> There is already a test in gdb.mi/mi-pending.exp that uses the 'times'
Andrew> argument -- previously this argument was being ignored, but is now
Andrew> used.
Looks good to me, thank you.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-04-13 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:19 [PATCH 0/2] testsuite: small tweaks to MI testing Andrew Burgess
2023-04-11 11:19 ` [PATCH 1/2] gdb/testsuite: avoid {"} pattern in lib/mi-support.exp Andrew Burgess
2023-04-13 13:42 ` Tom Tromey
2023-04-11 11:19 ` [PATCH 2/2] gdb/testsuite: accept script argument for mi_make_breakpoint_pending Andrew Burgess
2023-04-13 13:48 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8hz6ghb.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).