From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 615273858C50 for ; Fri, 17 Mar 2023 22:17:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 615273858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 906BD1004061C for ; Fri, 17 Mar 2023 22:17:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dIOJpJGRiUEmJdIOJp6JnY; Fri, 17 Mar 2023 22:17:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=TLSA93pa c=1 sm=1 tr=0 ts=6414e703 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=sBDdZmpGJ_HdricVOhgA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZnXu08IGMoHtUr4VHTJLcojxNHzW9E+SRWyr6FuZ8kA=; b=QiPD2okj3DSg62zk9mdoL0VZIU QeqcO3Yfp9Lv8R7v+r90fXBhBNvyeeVSqCeJ9MbimAcJADLYSmsxBcUDr6dOM6C72KwF8lUZ8/exD Kxq1A+XzPDuAVFJl/hMafPQcR; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:55304 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pdIOJ-003vO4-9x; Fri, 17 Mar 2023 16:17:39 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix line table regression References: <20230317131437.1852342-1-tom@tromey.com> <822a503a-66fb-fcef-ce9f-3eb0628d6697@simark.ca> X-Attribution: Tom Date: Fri, 17 Mar 2023 16:17:36 -0600 In-Reply-To: <822a503a-66fb-fcef-ce9f-3eb0628d6697@simark.ca> (Simon Marchi's message of "Fri, 17 Mar 2023 11:21:39 -0400") Message-ID: <87v8izaupr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pdIOJ-003vO4-9x X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (prentzel) [71.211.185.113]:55304 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> It does fix the issue in do_mixed_source_and_assembly I have seen. I'm going to check it in. Simon> I like the idea of having a separate type to catch things at compile Simon> time. I would like for it to be used in other objects using unrelocated Simon> addresses. I'll take a quick look. Simon> I'm just afraid that some code paths will always need to be Simon> handle both relocated and unrelocated addresses, so the distinction Simon> may not always be completely clear cut. For instance, your patch shows Simon> that gdbarch_addr_bits_remove works with both relocated and relocated Simon> addresses. Yeah. The contract on some of these things is a bit vague for my taste, as well. Simon> If this becomes more widespread, I think it would be nice to have some Simon> helper methods like this: Simon> unrelocated_addr objfile::unrelocated (CORE_ADDR); Simon> CORE_ADDR objfile::relocate (unrelocated_addr); Simon> It would make the code a bit clearer about what the intention is, versus Simon> just doing additions and subtractions. I think they'd have to take the section index as well, but yeah. Tom