From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 7810C3858D20 for ; Fri, 27 Jan 2023 19:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7810C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd31.google.com with SMTP id c66so2326742iof.12 for ; Fri, 27 Jan 2023 11:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=e66NbcjpuTk92KZ5fMzLs5q74tog6//Sk3bjrW62r4A=; b=KSY2HTW6HB7eEKeGpAHdOd0xAVTvc/jaQ+xQAbCOmMcxS3LKrbl/hCmBgN7U7DxM0G PGTOknooZQgP/+OuYbecJHIv9G6BkbW5SE10T/QOSnb9bs9d8iJoAW2nefelmMlrv5i0 EFJ5c7WtV9MQAD3MymbM6G+xz1hV5aHT2gSdGHOXvq7hWZ3ciAcO+X4TZ1oku171VE2Q Q3Okke7V8mXBF/4LZhOTfnVwhLDaYmsZHDPgtkGaBzvy+sl//7/3stOP/qKJ8v2BpPVO 3wliAoOIyotuq1OIBhFe3mVyZ/i2bESLCsrNxn/8VIv5KhYsk4dTB62iXFtJssAGbjXa x56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e66NbcjpuTk92KZ5fMzLs5q74tog6//Sk3bjrW62r4A=; b=8BzfkN69ZPys1SyknVhl48C5eATMQAWZxhzW62olwdyRY5KFsuMCdsBGLP29zFWvID mCyfSGIrqLbuWrFBErEFdTILJUN0iRPcVbJlC+AJtMnswzWmiiGQm85CwqqQrxlQ8v6j OaxHB7D3t5nUxFZa22V/PJklDi86gVFhlRObU796RbZ0WLVeRfg1076tQ0G4wHuB8FNt SZlj8PiqcGmVAaqg43hb4wBp9ozV30J06IaXMqRzPbqwPHbQ0PKVgxte6ZchE9ClzWeS X537yL+wiYCi5haCuz46T3ajyFLVcggotPz2fCoRttSf6iGdp+L1ycFzqnJNTs0ppW4J WPUw== X-Gm-Message-State: AFqh2krO4+KaKHIXOe7kYZvySf8uCeEX5dCNomHFxSTSvyyp7ZXz1hAm 8hHb7nnbtHnTEch9f8LY2TmdIw== X-Google-Smtp-Source: AMrXdXsrJJ80SGURzNRfzBRFAhn6muzoYYPl9PE/4gfiSAgZ+yVpCq2rFhJnrFob+NKWD2d8qFs7Tw== X-Received: by 2002:a05:6602:3150:b0:6ed:1e9c:fb5 with SMTP id m16-20020a056602315000b006ed1e9c0fb5mr27849664ioy.10.1674849456797; Fri, 27 Jan 2023 11:57:36 -0800 (PST) Received: from murgatroyd (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id q14-20020a02b04e000000b0039decb5b452sm1829597jah.65.2023.01.27.11.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 11:57:36 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: Andrew Burgess via Gdb-patches , Simon Marchi , Tom Tromey , Andrew Burgess Subject: Re: [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader References: <20230110183338.2623088-1-tromey@adacore.com> <20230110183338.2623088-5-tromey@adacore.com> <871qnt2bob.fsf@tromey.com> <26ba8dcf-3f4e-983d-bbb8-a61c4b94c47d@simark.ca> <87wn58uvuu.fsf@redhat.com> <87ilgsqcc3.fsf@tromey.com> X-Attribution: Tom Date: Fri, 27 Jan 2023 12:57:35 -0700 In-Reply-To: <87ilgsqcc3.fsf@tromey.com> (Tom Tromey's message of "Fri, 27 Jan 2023 07:30:36 -0700") Message-ID: <87v8krpx74.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew> The underlying problem is that we use a different sort predicate for the Andrew> std::lower_bound and std::upper_bound calls (in some cases) than when we Andrew> sorted this list. I'm not sure this can ever work correctly. Tom> Yeah, that was my conclusion as well. Well, after talking to Simon on irc, I think my conclusion was wrong. I've sent a patch to fix the problem. Please take a look. thanks, Tom