From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id E26F33858D28 for ; Wed, 25 Jan 2023 21:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E26F33858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 1D7F61004915D for ; Wed, 25 Jan 2023 21:26:49 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KnI8pWH44gsICKnI8pYIMk; Wed, 25 Jan 2023 21:26:49 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=H7Ief8Ui c=1 sm=1 tr=0 ts=63d19e99 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tiaJ3RZMyzDpuV/cAhGqB0k0I3kcSE+0ZWPeLGvgbVg=; b=jLm8L3rsU7rfADXSUOp/puYmgf kTS2b4uQDbzV5jAZmdJfivNarUcl0/MTRd8rA0tO//IUHueov7OKMn6AiJwGBpf60Zwh1Mp9GRXpj aaKjwwmOMSahcNH68IMeEWOI+; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:35202 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKnI8-0042Gg-As; Wed, 25 Jan 2023 14:26:48 -0700 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [RFC 0/3] [gdb/testsuite] Introduce is_x86_64_m64_target References: <20230125200626.29340-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 25 Jan 2023 14:26:44 -0700 In-Reply-To: <20230125200626.29340-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 25 Jan 2023 21:06:23 +0100") Message-ID: <87v8kutiej.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKnI8-0042Gg-As X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:35202 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> I used a refactoring setup I wrote in python for another refactoring to Tom> rewrite: Tom> ... Tom> if { ![istarget x86_64-*-* ] || ![is_lp64_target] } { Tom> verbose "Skipping ${testfile}." Tom> return Tom> } Tom> ... Tom> into: Tom> ... Tom> require is_x86_64_m64_target Tom> ... Tom> It also handles the elseif case. Tom> Due to a recent commit, only the elseif cases are transformed, the others Tom> have been handled already. If you want the existing requires could be converted to use the new proc. Seems a little simpler. I sent a comment to one patch but otherwise this looks good to me. Thanks for doing it. FWIW I also have some refactoring scripts, but mine are idiosyncratically written in emacs lisp, which is convenient in some ways (easier to do multi-line edits, and back in the day I could have them make ChangeLog entries) but worse in others (slow). Tom