From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 85888385457D for ; Mon, 12 Dec 2022 17:56:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85888385457D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 5EF1F1003FBCC for ; Mon, 12 Dec 2022 17:55:49 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 4n1pps44CiQCL4n1ppC1p2; Mon, 12 Dec 2022 17:55:49 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BYIdbph2 c=1 sm=1 tr=0 ts=63976b25 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=MtXh0z3Yg8bN90WBpi8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TV57RJml6hCHRcB8pCt/inKychLwLXBqsYbfGvZlbUo=; b=Ed4zyhNHLwYViPvGy3iHp7w3Pm /4+nWGIh71Y52GiWvxJUMUWH72sbW9FTJ1kQL9h01cnXlfEkxqXBqBNlBF4tZiGF4uMxx1AThqTNT bmaQrqLNqOwZykf0HDZHoo+8A; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56960 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p4n1o-000Dc4-SI; Mon, 12 Dec 2022 10:55:48 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 2/6] gdb/testsuite: fix gdb.trace/unavailable-dwarf-piece.exp with Clang References: X-Attribution: Tom Date: Mon, 12 Dec 2022 10:55:46 -0700 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Fri, 11 Nov 2022 16:36:21 +0000") Message-ID: <87v8mgfqvx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p4n1o-000Dc4-SI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56960 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> Currently, the unavailable-dwarf-piece.exp script names the assembler Andrew> file using standard_output_file, in this commit I've switched to make Andrew> use of standard_testfile, as that seems to be the more common way of Andrew> doing this sort of thing. I think this caused the .S file to be created outside of the test's directory. Using standard_output_file would fix this. I think it's more normal to do this as well; searching for "set asm_file" yields a lot of hits of the form: set asm_file [standard_output_file $srcfile2] So if this change isn't needed to make the test work with clang, I'd suggest reverting this part. Tom