From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id A0C453858D1E for ; Wed, 30 Nov 2022 16:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0C453858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 062B710047C28 for ; Wed, 30 Nov 2022 16:05:05 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 0Pa4pVbYe6wx10Pa4pMwa4; Wed, 30 Nov 2022 16:05:04 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=TvgjOBbh c=1 sm=1 tr=0 ts=63877f31 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=d57OVqSfjT4pq2In8fkA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=l5e+iw+o6v3SLp0nZxhSTwC+r1ToYFm6xkftb+61ix0=; b=BusobMpP6P1p2lxc9/GMPUhGW+ EKrsKj4BaacVNvZkG+z4WeE+stdUd5SRvljjvDRtbWR3pYfwYXqPa9QcQkgQK8JSr+Lpw8mqsFldA AqZS1CFcvhZDYJL+ZV7iEwjqQ; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56910 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0Pa4-001WWo-Cf; Wed, 30 Nov 2022 09:05:04 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 2/3] gdb: break up core_target initialization References: <20221129025048.44490-1-simon.marchi@polymtl.ca> <20221129025048.44490-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 30 Nov 2022 09:05:02 -0700 In-Reply-To: <20221129025048.44490-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 21:50:47 -0500") Message-ID: <87v8mwmnrl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p0Pa4-001WWo-Cf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56910 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> diff --git a/gdb/inferior.h b/gdb/inferior.h Simon> index 909e1819922d..a4a0304052e6 100644 Simon> --- a/gdb/inferior.h Simon> +++ b/gdb/inferior.h Simon> @@ -50,6 +50,7 @@ struct thread_info; Simon> #include "progspace.h" Simon> #include "registry.h" Simon> +#include "observable.h" It seems strange for this hunk to be in this patch. Is it needed at all? Tom