From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 198213858D1E for ; Thu, 10 Nov 2022 18:22:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 198213858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 67ED810045467 for ; Thu, 10 Nov 2022 18:21:55 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id tCBXoTCtpIyPJtCBXodmQd; Thu, 10 Nov 2022 18:21:55 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Kb0XDSUD c=1 sm=1 tr=0 ts=636d4143 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=SBQo8c9l0jd925xuJhAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Vjcv4NcMGc6KhLeR2bvTjaVOatpjOAjKobCvje1t3Lo=; b=wYTSsUUwIFdqQw8MEoJjtDagRb kW2UqyndXh57pi37sKbTHUVN5yk98SwHJgS6F+kV/5DWDXtD835Mch0biJCGXc4Ajle0/feNaSIAz FXcMIhYgFOh2AbOXCUDH7miCh; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56828 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1otCBX-00381V-2E; Thu, 10 Nov 2022 11:21:55 -0700 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH v2 8/9] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp References: <20221107134604.596986-1-blarsen@redhat.com> <20221107134604.596986-9-blarsen@redhat.com> X-Attribution: Tom Date: Thu, 10 Nov 2022 11:21:52 -0700 In-Reply-To: <20221107134604.596986-9-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Mon, 7 Nov 2022 14:46:04 +0100") Message-ID: <87v8nmy8jj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1otCBX-00381V-2E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56828 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> gdb.cp/temargs.exp last 2 tests always setup an XFAILs, despite checking Bruno> for old gcc versions. However, Clang does not fail in this test, Bruno> turning into XPASSes and slighty annoying when comparing between Bruno> compilers. To change this, make the xfails only happen if we using gcc. Bruno> if $have_older_template_gcc { setup_xfail "*-*-*" Bruno> -} else { setup_xfail gcc/49546 "*-*-*" } Bruno> +} elseif $using_gcc { setup_xfail gcc/49546 "*-*-*" } ... Bruno> +} elseif $using_gcc { setup_xfail gcc/49546 "*-*-*" } IMO it's better Tcl style to brace the condition, like "elseif {$using_gcc}" This is ok with this tweak. Tom