From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 9FAA73858D32 for ; Tue, 18 Oct 2022 18:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FAA73858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 97F6F10048ED8 for ; Tue, 18 Oct 2022 18:43:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id krYPovr4bN3CskrYQotMXZ; Tue, 18 Oct 2022 18:43:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=MNKlJOVl c=1 sm=1 tr=0 ts=634ef3ba a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=Ev3AdwcLBAr2ya5lV_EA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GZO6gaMxelPD/qXCwlW3rYqgt5ZmZT1BDKRj6M4hICE=; b=Qjy3TZV0JTnZRhdBfo9vCSovEh 6ZdePyggh9K4CLNSMr3ehh1l9IVuDcUAsMGO07/pHG0duNss8VXnyu18D5RZyj82opguQuKHS0RTJ emw8FM1HfbEV2xlald4178kY4; Received: from 71-211-181-169.hlrn.qwest.net ([71.211.181.169]:56700 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1okrYP-001KNX-7L; Tue, 18 Oct 2022 12:43:05 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH] gdb: check for groups with duplicate names in reggroups:add References: <20221018141733.29298-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 18 Oct 2022 12:42:58 -0600 In-Reply-To: <20221018141733.29298-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 18 Oct 2022 10:17:33 -0400") Message-ID: <87v8ohgeh9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.181.169 X-Source-L: No X-Exim-ID: 1okrYP-001KNX-7L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-181-169.hlrn.qwest.net (murgatroyd) [71.211.181.169]:56700 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2022 18:43:27 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In the downstream ROCm GDB port, we would create multiple register Simon> groups with duplicate names. While it did not really hurt, it certainly Simon> wasn't the intent. And I don't think it ever makes sense to do so. Simon> To catch these, change the assert in reggroups::add to check for Simon> duplicate names. It's no longer necessary to check for duplicate Simon> reggroup pointers, because adding the same group twice would be caught Simon> by the duplicate name check. I haven't looked but would it be possible for malformed XML from the target to trigger this assert? Tom