From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 26FDC3857C56 for ; Mon, 10 Oct 2022 16:39:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26FDC3857C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 2730F1004B4FB for ; Mon, 10 Oct 2022 16:39:19 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id hvoEoiXiwdqKAhvoEo52uQ; Mon, 10 Oct 2022 16:39:19 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DLdKXwBb c=1 sm=1 tr=0 ts=63444ab7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=dMsMVSbFHnII570hIeEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UeTVldzTmAAGjSc1UgwdDnvVmPe0f/skrCn7AgnaOZg=; b=aCOKhSZidTsJEn6yV9H63ckZ71 uvzYXLOhuGfz6cW7OwPAJqVSu82ViVP12KRxTrQSk/ZMnbeBAGia7BfQNPXTtwVhtr+xo+AzE9cwt 5S0Op5HuRrAscFGZh5AMOZ0zI; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:36646 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ohvoD-003sHR-PH; Mon, 10 Oct 2022 10:39:17 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Tom Tromey , Andrew Burgess Subject: Re: [PATCH v2 05/18] Don't use wchar_printable in print_wchar References: <20220217220547.3874030-1-tom@tromey.com> <20220217220547.3874030-6-tom@tromey.com> <20220222153635.GS2571@redhat.com> X-Attribution: Tom Date: Mon, 10 Oct 2022 10:39:12 -0600 In-Reply-To: <20220222153635.GS2571@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 22 Feb 2022 15:36:35 +0000") Message-ID: <87v8oriqfj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ohvoD-003sHR-PH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (prentzel) [71.211.160.49]:36646 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 16:39:32 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> I wonder if we should leave some comment here that just says something Andrew> like: Andrew> /* If any additional cases are added to this switch block, then the Andrew> function wchar_printable will likely need updating too. */ I made this change. Tom